Skip to content

add xset package to simplify set-kind controller development #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2025

Conversation

AnnaYue
Copy link
Collaborator

@AnnaYue AnnaYue commented Jun 10, 2025

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@AnnaYue AnnaYue requested review from zoumo and ColdsteelRail June 10, 2025 12:10
ColdsteelRail and others added 3 commits July 21, 2025 16:37
* update comment

* add GetXSetPatch for controller

* add availableReplicas updatedReadyReplicas ScheduledReplicas

* remove GetXTemplate, add GetXSetPatch GetXObjectFromRevision

* const to var
* use lifecycle labels from kube-api

* fix lisence
Copy link
Member

@ColdsteelRail ColdsteelRail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ColdsteelRail ColdsteelRail merged commit ef81885 into main Jul 23, 2025
14 of 16 checks passed
@ColdsteelRail ColdsteelRail deleted the xset branch July 23, 2025 03:13
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants