LibWeb: Add synthetic height for contenteditable elements #6670
+89
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikiubo
force-pushed
the
content_editable
branch
3 times, most recently
from
2335efc to
52cdb3d
Compare
gmta
reviewed
Nov 7, 2025
mikiubo
force-pushed
the
content_editable
branch
7 times, most recently
from
c22023c to
2f0df03
Compare
Contenteditable elements that would otherwise have zero height now get a minimum height equal to their line-height. This ensures they remain clickable and usable for text editing. This fixes the WPT test: contenteditable/synthetic-height.html
mikiubo
force-pushed
the
content_editable
branch
from
2f0df03 to
43df8ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contenteditable elements that would otherwise have zero height now get a minimum height equal to their line-height. This ensures they remain clickable and usable for text editing.
This fixes the WPT test:
contenteditable/synthetic-height.html