git apps support #20
Merged
git apps support #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds GitHub Apps support to the SCM client library by introducing a new AppsService interface and implementing it across all supported SCM drivers.
- Adds a new AppsService interface with methods for managing GitHub Apps and installations
- Implements the apps service for all SCM drivers, with full functionality for GitHub and stub implementations returning
ErrNotSupportedfor other drivers - Includes comprehensive test coverage for the GitHub Apps implementation
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| scm/apps.go | Defines the AppsService interface and related data structures for GitHub Apps |
| scm/client.go | Adds the Apps field to the main Client struct |
| scm/driver/github/apps.go | Full implementation of AppsService for GitHub with conversion functions |
| scm/driver/github/apps_test.go | Comprehensive test suite for GitHub Apps functionality |
| scm/driver/github/user.go | Adds nil check to convertUser function |
| scm/driver/*/apps.go | Stub implementations returning ErrNotSupported for non-GitHub drivers |
| scm/driver/*/driver.go | Initializes Apps service in each driver's New function |
| scm/driver/github/testdata/*.json | Test data files for GitHub Apps API responses |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
rishabh-arya95
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.