Skip to content

Hyp 17516 Functions renamed #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rishabh-arya95 merged 3 commits into from
Aug 21, 2025
Merged

Hyp 17516 Functions renamed #23

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63f3f38
proxy support
rcchopra Aug 21, 2025
e5bb228
proxy support
rcchopra Aug 21, 2025
2ef1462
proxy support
rcchopra Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scm/driver/github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ import (
// New returns a new GitHub API client.
// This function maintains backward compatibility and creates a client without proxy.
func New(uri string) (*scm.Client, error) {
return NewWithProxy(uri, "")
return NewWithOptionalProxy(uri, "")
}

// NewWithProxy returns a new GitHub API client with optional proxy support.
// If proxyURL is empty or nil, no proxy will be used.
// If proxyURL is provided, all HTTP requests will be routed through the specified proxy.
func NewWithProxy(uri, proxyURL string) (*scm.Client, error) {
func NewWithOptionalProxy(uri, proxyURL string) (*scm.Client, error) {
base, err := url.Parse(uri)
if err != nil {
return nil, err
Expand Down Expand Up @@ -57,7 +57,7 @@ func NewWithProxy(uri, proxyURL string) (*scm.Client, error) {
client.Reviews = &reviewService{client}
client.Users = &userService{client}
client.Webhooks = &webhookService{client}

client.Client.Client = &http.Client{Transport: http.DefaultTransport}

if proxyURL != "" {
Expand All @@ -82,8 +82,8 @@ func NewDefault() *scm.Client {
// default api.github.com address with optional proxy support.
// If proxyURL is empty or nil, no proxy will be used.
// If proxyURL is provided, all HTTP requests will be routed through the specified proxy.
func NewDefaultWithProxy(proxyURL string) *scm.Client {
client, _ := NewWithProxy("https://api.github.com", proxyURL)
func NewDefaultWithOptionalProxy(proxyURL string) *scm.Client {
client, _ := NewWithOptionalProxy("https://api.github.com", proxyURL)
return client
}

Expand Down