Skip to content

Conversation

@LaravelFreelancerNL
Copy link
Owner

This pull request contains changes for migrating your test suite from PHPUnit to Pest automated by the Pest Converter.

Before merging, you need to:

  • Checkout the shift-130456 branch
  • Review all of the comments below for additional changes
  • Run composer update to install Pest with your dependencies
  • Run vendor/bin/pest to verify the conversion

@LaravelFreelancerNL
Copy link
Owner Author

LaravelFreelancerNL commented Oct 7, 2024

⚠️ Shift detected helper methods in the following PHPUnit tests. Currently Pest does not support namespaces. As such, these functions may result in a naming conflict.

While Shift converted these methods to functions in the new Pest test, you should review these files to see if these functions may be inlined or extracted to a custom helper.

  • ./tests/ArangoClientTest.php
  • ./tests/SchemaManagerUsersTest.php
  • ./tests/StatementTest.php

@LaravelFreelancerNL
Copy link
Owner Author

ℹ️ Shift converted common PHPUnit assertions to Pest expectations. However, there may also be opportunities to chain your expectations together.

For example:

// Before
expect($comment)->toBeArray();
expect($comment)->toHaveCount(3);
expect($comment)->toContain('foo');

// After
expect($comment)->toBeArray()->toHaveCount(3)->toContain('foo');

@LaravelFreelancerNL
Copy link
Owner Author

LaravelFreelancerNL commented Oct 7, 2024

⚠️ Shift detected references to the PHPUnit test runner (vendor/bin/phpunit) in the following files. You should review these instances to see if they may be updated to the Pest test runner (vendor/bin/pest).

  • ./composer.json

@LaravelFreelancerNL
Copy link
Owner Author

ℹ️ By default, Pest executes your tests sequentially within a single process. However, you may significantly decrease the time needed to run your tests by utilizing the --parallel option. You may review the documentation on parallel testing for additional details.

@LaravelFreelancerNL
Copy link
Owner Author

LaravelFreelancerNL commented Oct 7, 2024

❌ PHP syntax errors were detected after running your Shift. Often these are simply differences between the PHP version on the Shift server (8.2) and your project. Occasionally they are misplaced lines or duplicate import statements.

You may quickly check the PHP syntax locally by running php -l on the following files:

  • tests/ExceptionsTest.php
  • tests/SchemaManagerAnalyzersTest.php
  • tests/SchemaManagerCollectionsTest.php
  • tests/SchemaManagerDatabasesTest.php
  • tests/SchemaManagerGraphsTest.php
  • tests/SchemaManagerIndexesTest.php
  • tests/SchemaManagerUsersTest.php
  • tests/SchemaManagerViewsTest.php

@LaravelFreelancerNL LaravelFreelancerNL merged commit 162a0fd into next Oct 8, 2024
18 of 19 checks passed
@LaravelFreelancerNL LaravelFreelancerNL deleted the shift-130456 branch October 8, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants