Skip to content

Conversation

@gen0cide
Copy link

@gen0cide gen0cide commented Jun 1, 2023

The DCScrape.ps1 was unreadable in it's current form. Understand it's easier for in the moment pen testing, but for GitHub and community development, the one liner should be expanded. The benefit of this:

  1. More trustworthy
  2. Easier to modify and tweak as edge cases are identified.

To do this, I've gone ahead and tidy'd the DCScrape.ps1 script and created a Minify.ps1 that uses the PSMinifier Powershell module to create both a oneliner and a GZip'd one liner for easy execution.

This allows modification of the original DCScrape.ps1 script as well as quick transpiling into a oneliner for use during a pentest.

This was tested with PowerShell 7.3.4 on a arm64 macOS machine.

@ZephrFish
Copy link
Contributor

Point taken, additions look good will test in windows environment tomorrow

@ZephrFish ZephrFish requested a review from myexploit June 1, 2023 23:48
@ZephrFish ZephrFish added the enhancement New feature or request label Jun 1, 2023
@ZephrFish
Copy link
Contributor

We've changed up the code a bit to add in additional params and features, happy to merge the modified PSMinify code but you'll need to update your side before we can merge the branches

@ZephrFish ZephrFish requested review from ZephrFish and removed request for myexploit June 2, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants