Skip to content

Conversation

@doup2001
Copy link
Member

@doup2001 doup2001 commented Aug 4, 2025

📌 작업한 내용

  • 헤더에 따라서 리다이렉트 주소 변경
  • 기본값은 프런트 주소이고,
  • 헤더가 로컬 주소라면 로컬로 리다이렉트를 진행합니다.

🔍 참고 사항

  • 빠르게 테스트를 위해서 먼저 배포하겠습니다

🖼️ 스크린샷

🔗 관련 이슈

#108

✅ 체크리스트

  • 로컬에서 빌드 및 테스트 완료
  • 코드 리뷰 반영 완료
  • 문서화 필요 여부 확인

@doup2001 doup2001 requested review from RokChoi and soo0711 August 4, 2025 16:13
@doup2001 doup2001 self-assigned this Aug 4, 2025
@doup2001 doup2001 added the 📬 API 서버 API 통신 label Aug 4, 2025
@github-actions
Copy link

github-actions bot commented Aug 4, 2025

Test Results

106 tests  ±0   106 ✅ ±0   11s ⏱️ -1s
 49 suites ±0     0 💤 ±0 
 49 files   ±0     0 ❌ ±0 

Results for commit 333ec3d. ± Comparison against base commit c7727ea.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
com.seeat.server.security.handler.CustomOAuth2SuccessHandlerTest ‑ dev_profile_uses_dev_url()
com.seeat.server.security.handler.CustomOAuth2SuccessHandlerTest ‑ emailDuplicate_error_redirect()
com.seeat.server.security.handler.CustomOAuth2SuccessHandlerTest ‑ existingUser_cookieSet_redirect()
com.seeat.server.security.handler.CustomOAuth2SuccessHandlerTest ‑ newUser_extraInfo_redirect()
com.seeat.server.security.handler.CustomOAuth2SuccessHandlerTest ‑ emailDuplicate_shouldRedirectToDuplicateEmailPage()
com.seeat.server.security.handler.CustomOAuth2SuccessHandlerTest ‑ existingUser_shouldRedirectToHome_withTokenHeaders()
com.seeat.server.security.handler.CustomOAuth2SuccessHandlerTest ‑ newUser_shouldStoreTempUserInRedis_andRedirectToExtraInfo()
com.seeat.server.security.handler.CustomOAuth2SuccessHandlerTest ‑ noOriginHeader_shouldDefaultToDevUrl()

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 4, 2025

Test Coverage Report

File Coverage [79.8%] 🍏
CustomOAuth2SuccessHandler.java 79.8% 🍏
Total Project Coverage 53.71% 🍏

@doup2001 doup2001 merged commit b72f900 into develop Aug 4, 2025
2 checks passed
Copy link
Contributor

@soo0711 soo0711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기본값은 프런트 주소이고, 헤더가 로컬 주소라면 로컬로 리다이렉트하면 프론트 분들이 개발하실 때 편할 것 같습니다! 수고하셨습니다!

@doup2001 doup2001 linked an issue Aug 6, 2025 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📬 API 서버 API 통신

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ feat : 사용자의 헤더에 따라 로그인 리다이렉트 주소 변경

3 participants