fix: add ttl to captain migration job

[ambersun1234]

Summary by Sourcery

Enhancements:

• Configure the captain migration Kubernetes Job to be garbage-collected 1 hour after completion via ttlSecondsAfterFinished.

---

Summary by cubic

Added a TTL to the captain migration Kubernetes Job so completed jobs auto-remove, reducing cluster noise. TTL is configurable via values.yaml (captain.migration.ttl) and defaults to 1 hour; aligns with AGH-874 to keep the job ephemeral.

^{Written for commit 261ba6a. Summary will update automatically on new commits.}

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a TTL to the Captain migration Kubernetes Job so completed Jobs are automatically cleaned up after one hour.

Sequence diagram for Captain migration Job lifecycle with TTL

sequenceDiagram
    actor Developer
    participant HelmChart
    participant KubernetesAPI
    participant CaptainMigrationJob
    participant CaptainMigrationPod as Pod
    participant TTLController

    Developer->>HelmChart: Deploy release (includes captain-migration-job)
    HelmChart->>KubernetesAPI: Apply CaptainMigrationJob manifest
    KubernetesAPI->>CaptainMigrationJob: Create Job with ttlSecondsAfterFinished 3600
    CaptainMigrationJob->>KubernetesAPI: Request Pod creation
    KubernetesAPI->>CaptainMigrationPod: Create Pod
    CaptainMigrationPod-->>CaptainMigrationJob: Report completion
    CaptainMigrationJob-->>KubernetesAPI: Job status succeeded
    KubernetesAPI-->>TTLController: Expose Job with ttlSecondsAfterFinished
    TTLController-->>TTLController: Wait 3600 seconds after completion
    TTLController->>KubernetesAPI: Delete CaptainMigrationJob and associated Pods

Loading

File-Level Changes

Change	Details	Files
Configure automatic cleanup of the Captain migration Job after completion.	Set ttlSecondsAfterFinished to 3600 on the Captain migration Job spec to enforce a one-hour time-to-live for completed Jobs	charts/agh3/templates/captain/captain-migration-job.yml

Assessment against linked issues

Issue	Objective	Addressed	Explanation
AGH-874	Add a new Kubernetes Job resource for the migration task (migration k8s job) to the charts/agh3 Helm chart.	❌	The PR only adds ttlSecondsAfterFinished: 3600 to an existing captain-migration-job.yml manifest. It does not introduce a new migration Kubernetes Job resource, so the core objective of新增 migration k8s job is not implemented in this PR.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider making ttlSecondsAfterFinished configurable via values.yaml (with a sensible default) rather than hard-coding 3600, so different environments can tune how long completed jobs are retained.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider making `ttlSecondsAfterFinished` configurable via `values.yaml` (with a sensible default) rather than hard-coding `3600`, so different environments can tune how long completed jobs are retained.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[cubic-dev-ai]

No issues found across 1 file