bump: try `deepspeed >=0.14.1,<=0.15.0` #21076

Borda · 2025-08-15T14:19:42Z

What does this PR do?

'Let''s see if we are fine with this bump

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21076.org.readthedocs.build/en/21076/

github-actions · 2025-08-15T14:20:06Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu-guardian	success	✅

These checks are required after the changes to .actions/assistant.py, requirements/fabric/strategies.txt, src/lightning/fabric/strategies/deepspeed.py, requirements/pytorch/strategies.txt, tests/tests_pytorch/utilities/test_compile.py, pyproject.toml.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs) (testing Lightning \| latest)	success	✅
pytorch-lightning (GPUs) (testing PyTorch \| oldest)	success	✅
pytorch-lightning (GPUs) (testing PyTorch \| latest)	success	✅

These checks are required after the changes to .actions/assistant.py, .azure/gpu-tests-pytorch.yml, requirements/pytorch/strategies.txt, tests/tests_pytorch/utilities/test_compile.py, pyproject.toml, requirements/fabric/strategies.txt, src/lightning/fabric/strategies/deepspeed.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	success	✅

These checks are required after the changes to requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt, src/lightning/fabric/strategies/deepspeed.py.

🟢 fabric: Docs

Check ID	Status
docs-make (fabric, doctest)	success	✅
docs-make (fabric, html)	success	✅

These checks are required after the changes to src/lightning/fabric/strategies/deepspeed.py, requirements/fabric/strategies.txt, pyproject.toml.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-make (pytorch, doctest)	success	✅
docs-make (pytorch, html)	success	✅

These checks are required after the changes to .actions/assistant.py, requirements/pytorch/strategies.txt, pyproject.toml.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.10, 2.1.2, 12.1.1)	success	✅
build-cuda (3.11, 2.2.2, 12.1.1)	success	✅
build-cuda (3.11, 2.3.1, 12.1.1)	success	✅
build-cuda (3.11, 2.4.1, 12.1.1)	success	✅
build-cuda (3.12, 2.5.1, 12.1.1)	success	✅
build-cuda (3.12, 2.6.0, 12.4.1)	success	✅
build-pl (3.10, 2.1, 12.1.1)	success	✅
build-pl (3.11, 2.2, 12.1.1)	success	✅
build-pl (3.11, 2.3, 12.1.1)	success	✅
build-pl (3.11, 2.4, 12.1.1)	success	✅
build-pl (3.12, 2.5, 12.1.1)	success	✅
build-pl (3.12, 2.6, 12.4.1)	success	✅
build-pl (3.12, 2.7, 12.6.3)	success	✅
build-pl (3.12, 2.8, 12.6.3, true)	success	✅

These checks are required after the changes to .actions/assistant.py, dockers/release/Dockerfile, requirements/pytorch/strategies.txt, requirements/fabric/strategies.txt.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu-guardian	success	✅

These checks are required after the changes to .actions/assistant.py, requirements/fabric/strategies.txt, src/lightning/fabric/strategies/deepspeed.py, tests/tests_fabric/strategies/launchers/test_multiprocessing_integration.py, pyproject.toml.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs) (testing Fabric \| oldest)	success	✅
lightning-fabric (GPUs) (testing Fabric \| latest)	success	✅
lightning-fabric (GPUs) (testing Lightning \| latest)	success	✅

These checks are required after the changes to .actions/assistant.py, .azure/gpu-tests-fabric.yml, requirements/fabric/strategies.txt, src/lightning/fabric/strategies/deepspeed.py, tests/tests_fabric/strategies/launchers/test_multiprocessing_integration.py, pyproject.toml.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to .actions/assistant.py, requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt, src/lightning/fabric/strategies/deepspeed.py, pyproject.toml.

🟢 install

Check ID	Status
install-pkg-guardian	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/fabric/strategies/deepspeed.py, requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

codecov · 2025-08-15T14:27:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (8ff43d4) to head (47167b6).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #21076   +/-   ##
=======================================
  Coverage      87%      87%           
=======================================
  Files         269      269           
  Lines       23509    23506    -3     
=======================================
- Hits        20494    20492    -2     
+ Misses       3015     3014    -1

for more information, see https://pre-commit.ci

…tning into bump/deepspeed

for more information, see https://pre-commit.ci

…tning into bump/deepspeed

Borda · 2025-08-15T18:44:13Z

This seems a bit unrelated:

FAILED strategies/launchers/test_multiprocessing_integration.py::test_memory_sharing_disabled[ddp_fork] - torch.multiprocessing.spawn.ProcessRaisedException: 

-- Process 0 terminated with the following error:
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/torch/multiprocessing/spawn.py", line 90, in _wrap
    fn(i, *args)
  File "/Users/runner/work/pytorch-lightning/pytorch-lightning/src/lightning_fabric/strategies/launchers/multiprocessing.py", line 142, in _wrapping_function
    results = function(*args, **kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/work/pytorch-lightning/pytorch-lightning/src/lightning_fabric/fabric.py", line 934, in _wrap_with_setup
    return to_run(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/work/pytorch-lightning/pytorch-lightning/tests/tests_fabric/strategies/launchers/test_multiprocessing_integration.py", line 58, in _test_memory_sharing_disabled
    fabric.barrier()
  File "/Users/runner/work/pytorch-lightning/pytorch-lightning/src/lightning_fabric/fabric.py", line 547, in barrier
    self._strategy.barrier(name=name)
  File "/Users/runner/work/pytorch-lightning/pytorch-lightning/src/lightning_fabric/strategies/ddp.py", line 162, in barrier
    torch.distributed.barrier()
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/torch/distributed/c10d_logger.py", line 81, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/torch/distributed/distributed_c10d.py", line 4792, in barrier
    device = torch._C._get_accelerator()
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: Please register PrivateUse1HooksInterface by `RegisterPrivateUse1HooksInterface` first.

…tning into bump/deepspeed

lantiga · 2025-08-19T11:12:19Z

requirements/fabric/strategies.txt

@@ -5,5 +5,5 @@

 # note: is a bug around 0.10 with `MPS_Accelerator must implement all abstract methods`
 #  shall be resolved by https://github.com/microsoft/DeepSpeed/issues/4372


Not for this PR, but this was resolved, so maybe we can relax in the future

Yes, I will continue in relaxing. I just wanted to do it in smaller steps so it's safer to land...

for more information, see https://pre-commit.ci

* try `deepspeed >=0.14.1,<=0.15.0` * drop from oldest * pip uninstall -y deepspeed * error::DeprecationWarning

bump: try deepspeed >=0.14.1,<=0.15.0

f775d32

Borda requested review from lantiga, tchaton, justusschock and ethanwharris as code owners August 15, 2025 14:19

github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Aug 15, 2025

drop from oldest

3119822

github-actions bot added the ci Continuous Integration label Aug 15, 2025

pre-commit-ci bot and others added 3 commits August 15, 2025 16:24

[pre-commit.ci] auto fixes from pre-commit.com hooks

a5fc71f

for more information, see https://pre-commit.ci

docker

a83102c

Merge branch 'bump/deepspeed' of https://github.com/Lightning-AI/ligh…

b53a7b2

…tning into bump/deepspeed

github-actions bot added the dockers label Aug 15, 2025

Borda added 6 commits August 15, 2025 18:59

bash

5bd96ec

echo

64e6cc8

arg

17328ef

flaky test_memory_sharing_disabled

8abb07f

pip uninstall -y deepspeed

a30d5bf

error::DeprecationWarning

b73c4cb

github-actions bot added the package label Aug 15, 2025

Borda and others added 4 commits August 15, 2025 20:21

warns

3024471

[pre-commit.ci] auto fixes from pre-commit.com hooks

123a122

for more information, see https://pre-commit.ci

warns

1837dbd

Merge branch 'bump/deepspeed' of https://github.com/Lightning-AI/ligh…

dd19f16

…tning into bump/deepspeed

Borda and others added 2 commits August 18, 2025 13:01

Merge branch 'master' into bump/deepspeed

2176375

warn

0eea296

Borda and others added 2 commits August 18, 2025 14:01

Merge branch 'bump/deepspeed' of https://github.com/Lightning-AI/ligh…

fa5af07

…tning into bump/deepspeed

Merge branch 'master' into bump/deepspeed

3cb99b9

Borda mentioned this pull request Aug 18, 2025

debug failing tests for Fabric with ddp_fork on PT 2.8 [wip] #21093

Open

7 tasks

lantiga approved these changes Aug 19, 2025

View reviewed changes

Borda and others added 3 commits August 19, 2025 13:17

Merge branch 'master' into bump/deepspeed

048966a

[pre-commit.ci] auto fixes from pre-commit.com hooks

fba4586

for more information, see https://pre-commit.ci

update

47167b6

Borda merged commit ad54bc1 into master Aug 19, 2025
187 of 192 checks passed

Borda deleted the bump/deepspeed branch August 19, 2025 13:13

matsumotosan pushed a commit to matsumotosan/pytorch-lightning that referenced this pull request Aug 19, 2025

bump: try deepspeed >=0.14.1,<=0.15.0 (Lightning-AI#21076)

93cbe94

* try `deepspeed >=0.14.1,<=0.15.0` * drop from oldest * pip uninstall -y deepspeed * error::DeprecationWarning

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bump: try `deepspeed >=0.14.1,<=0.15.0` #21076

bump: try `deepspeed >=0.14.1,<=0.15.0` #21076

Uh oh!

Borda commented Aug 15, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

codecov bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

Borda commented Aug 15, 2025

Uh oh!

lantiga Aug 19, 2025

Uh oh!

Borda Aug 19, 2025

Uh oh!

Uh oh!

Uh oh!

		@@ -5,5 +5,5 @@

		# note: is a bug around 0.10 with `MPS_Accelerator must implement all abstract methods`
		# shall be resolved by https://github.com/microsoft/DeepSpeed/issues/4372

bump: try deepspeed >=0.14.1,<=0.15.0 #21076

bump: try deepspeed >=0.14.1,<=0.15.0 #21076

Uh oh!

Conversation

Borda commented Aug 15, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

PR review

Uh oh!

github-actions bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡ Required checks status: All passing 🟢

Groups summary

Uh oh!

codecov bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Borda commented Aug 15, 2025

Uh oh!

lantiga Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Borda Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bump: try `deepspeed >=0.14.1,<=0.15.0` #21076

bump: try `deepspeed >=0.14.1,<=0.15.0` #21076

Borda commented Aug 15, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Aug 15, 2025 •

edited

Loading

codecov bot commented Aug 15, 2025 •

edited

Loading