Skip to content

Conversation

GdoongMathew
Copy link
Contributor

@GdoongMathew GdoongMathew commented Sep 4, 2025

What does this PR do?

Fixes #20307

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21164.org.readthedocs.build/en/21164/

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Sep 4, 2025
@Borda
Copy link
Member

Borda commented Sep 4, 2025

since the change is with Fabric lets add slo relevant test to fabric

@bhimrazy
Copy link
Collaborator

bhimrazy commented Sep 5, 2025

Will look into the other failing tests shortly.

@GdoongMathew
Copy link
Contributor Author

Hi @bhimrazy & @Borda , my bad, I forgot to set back the default dtype in torch in the newly added unittest. Should be fixed in c323507

Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (d204cb1) to head (0e729d6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21164   +/-   ##
=======================================
- Coverage      87%      87%   -0%     
=======================================
  Files         269      269           
  Lines       23656    23657    +1     
=======================================
- Hits        20636    20634    -2     
- Misses       3020     3023    +3     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trainer's .init_module() context does not initialize model on target device
4 participants