-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Set _DeviceDtypeModuleMixin
_device from torch's default device function
#21164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GdoongMathew
wants to merge
11
commits into
Lightning-AI:master
Choose a base branch
from
GdoongMathew:fix/trainer_init_module_device
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Set _DeviceDtypeModuleMixin
_device from torch's default device function
#21164
GdoongMathew
wants to merge
11
commits into
Lightning-AI:master
from
GdoongMathew:fix/trainer_init_module_device
+49
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
approved these changes
Sep 4, 2025
since the change is with Fabric lets add slo relevant test to fabric |
bhimrazy
reviewed
Sep 5, 2025
Co-authored-by: Bhimraj Yadav <[email protected]>
Will look into the other failing tests shortly. |
…and_dtype is finished.
…into fix/trainer_init_module_device
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21164 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 269 269
Lines 23656 23657 +1
=======================================
- Hits 20636 20634 -2
- Misses 3020 3023 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20307
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21164.org.readthedocs.build/en/21164/