Skip to content

Conversation

vlapparov
Copy link

Add perplexity client to the eval framework

@vlapparov vlapparov requested review from cjumel and Copilot April 23, 2025 09:16
@vlapparov vlapparov self-assigned this Apr 23, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a new perplexity client in the evaluation framework by integrating a new client implementation and updating policy routing and argument parsing. Key changes include:

  • Importing and instantiating the PerplexityClient, along with obtaining its API key.
  • Adding an asynchronous function (run_perplexity_policy) to execute perplexity search requests.
  • Updating command-line argument choices to include the new perplexity policy.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
eval.py Integrated perplexity client into policy functions and argument parsers
clients/_perplexity.py Introduced PerplexityClient with API key validation and search method

Copy link
Contributor

@cjumel cjumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I jsut left a few comments/questions 🙂

@cjumel cjumel self-requested a review April 24, 2025 16:01
Copy link
Contributor

@cjumel cjumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just very minor stuff, otherwise all good!

Co-authored-by: Clément Jumel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants