-
Notifications
You must be signed in to change notification settings - Fork 2
feat: implement perplexity client #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for a new perplexity client in the evaluation framework by integrating a new client implementation and updating policy routing and argument parsing. Key changes include:
- Importing and instantiating the PerplexityClient, along with obtaining its API key.
- Adding an asynchronous function (run_perplexity_policy) to execute perplexity search requests.
- Updating command-line argument choices to include the new perplexity policy.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
eval.py | Integrated perplexity client into policy functions and argument parsers |
clients/_perplexity.py | Introduced PerplexityClient with API key validation and search method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I jsut left a few comments/questions 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just very minor stuff, otherwise all good!
Co-authored-by: Clément Jumel <[email protected]>
Add perplexity client to the eval framework