Skip to content

Conversation

cjumel
Copy link
Contributor

@cjumel cjumel commented Sep 16, 2025

Description

The main addition of this PR is a small set of improvments/fixes on types and code documentation (d811833), with the goal of making the docstrings and the types more accurate, remove unecessary ones and prepare for future API changes.

Then, I work on a few minor fixes, namely the PR template, which got out-of-date, and the python version.

Besides this, I made some work on standardazing this repository configs with other repositories we have at Linkup, which concretely means:

  • enable the standard rules we use (formatters or type checker setting for instance)
  • import the missing config files from our template repository

Since they are a lot of small changes in this PR, it might be easier to review it commit by commit.

Checklist

  • I have run the tests locally with make install-dev and make test
  • I have updated the README.md if my changes affected it
  • I have updated the package version in linkup/_version.py and pyproject.toml if I plan on creating a new release

@cjumel cjumel requested a review from vlapparov September 16, 2025 09:43
@cjumel cjumel marked this pull request as ready for review September 16, 2025 09:47
Copy link

@vlapparov vlapparov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One comment left- optional to address. Great job

@cjumel cjumel requested a review from vlapparov September 16, 2025 14:20
Copy link

@vlapparov vlapparov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjumel cjumel merged commit 6330633 into main Sep 16, 2025
2 checks passed
@cjumel cjumel deleted the cj/chores branch September 16, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants