Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the runtests race condition running
checkresult
before theresult
file is closed. This can happen when the test-process runs asynchronously and has not yet exited, keeping the from runtests redirected stdio descriptors in an open state.The mb2hal process, which exhibited the race, has another race fixed, where the signal handlers were installed too late in the process. Additionally, the mb2hal internal
quit_flag
must be declared volatile because it is written in the signal handler and read in separate threads.Finally, a longstanding bug in runtests prevented it to take multiple directories from the command-line when, for example, done using a wildcard. The expansion to find tests mistakenly used
$*
instead of$@
.