Skip to content

Conversation

enikao
Copy link
Contributor

@enikao enikao commented Mar 19, 2024

No description provided.

@enikao enikao requested a review from joswarmer March 19, 2024 20:04
Copy link
Contributor

@dslmeinte dslmeinte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the description of this directory and file structure as a README somewhere?

@enikao
Copy link
Contributor Author

enikao commented Mar 20, 2024

Can you add the description of this directory and file structure as a README somewhere?

Will do

@enikao
Copy link
Contributor Author

enikao commented Mar 20, 2024

I'm not sure whether we want one file per test case listing all steps, or one file per step with the directory being the test case.

Pro file per test:

  • Easier to execute, no file system shenanigans

Pro file per step:

  • Easier to navigate, read, write

Con storing tests themselves as model:

  • We would need to package the serialization chunk as property, as we want to test invalid chunks

@joswarmer
Copy link
Contributor

I foresee a maintenance problem with embedding chunks in the JSON test files.

We are using different tools (Freon, MPS, Java/Kotlin, ...) to read and write chunks, because we don't want to write bare JSON. These tools typically read/write chunks from a file. It is going to be hard to read/write the chunks embedded in the test files using these tools.

Maybe we should put the chunks in separate files and use the $variable syntax or something similar as values for chunks referring to a file containing a chunk.

@dslmeinte
Copy link
Contributor

I think the Java lib should mention the LionCore Built-ins as used language.

@enikao
Copy link
Contributor Author

enikao commented Apr 16, 2024

Maybe we should put the chunks in separate files and use the $variable syntax or something similar as values for chunks referring to a file containing a chunk.

How does this solve the problem that we have to refer to node ids we've got from a previous request?

@joswarmer
Copy link
Contributor

Maybe we should put the chunks in separate files and use the $variable syntax or something similar as values for chunks referring to a file containing a chunk.

How does this solve the problem that we have to refer to node ids we've got from a previous request?

It doesn't, it is intended to make creating and changing the chunks in the testcases easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants