Prefer dependencies over selects (fix #13) #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in the Zephyr Kconfig recommendations [1], it is preferred to use `depends on`: > Avoid selecting symbols with prompts or dependencies. Prefer depends on. This can be related to zephyrproject-rtos/zephyr#52575 This commit is backward compatible as long as the REBOOT symbol is selected, which can be done mannually or through a subsystem (like LBM was doing). [1]: https://docs.zephyrproject.org/latest/build/kconfig/tips.html#select-recommendations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the Zephyr Kconfig recommendations 1, it is preferred to use
depends on:This can be related to zephyrproject-rtos/zephyr#52575
This commit is backward compatible as long as the REBOOT symbol is selected, which can be done mannually or through a subsystem (like LBM was doing).
This PR fixes the problem of not being able to build the project on new Zephyr due to a circular dependency (see #13 for details).