Skip to content

Conversation

@martiera
Copy link

Please review my improvements over sendACK.

@kanflo
Copy link

kanflo commented Nov 15, 2014

It's a good thing you added timeout while waiting for ack xmit but in my opinion you should resubmit the patch without the changes in whitespace.

@martiera
Copy link
Author

Yep, already doing :-)

M.

On 14:36, 15 Nov 2014, at 14:36, Johan Kanflo [email protected] wrote:

It's a good thing you added timeout while waiting for ack xmit but in
my opinion you should resubmit the patch without the changes in
whitespace.


Reply to this email directly or view it on GitHub:
#16 (comment)

@martiera
Copy link
Author

//

Fixed patch. No whitespaces more.
 
Citējot Johan Kanflo [email protected] :

It's a good thing you added timeout while waiting for ack xmit but in my opinion you should resubmit the patch without the changes in whitespace.

Reply to this email directly or view it on GitHub.

 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants