fix: typed @field
should not override other defined field
#3224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2171, fixes #2711
The problem
I found these issues while discussing in #3221.
In short, the typed
@field [T1] T2
should only apply when no types found for that specific key.I found a fix after some debugging, implementation details: #3221 (comment)
before
after
中文版
@field [T1] T2
似應該只在對應 key 找不到任何 type define 時才 apply解決方式是簡單將相關 infer logic 延後到查找完 class variable 的
setfield/setmethod
之後才處理