fix: incorrect generation of function signatures with tuple parameters #3251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tuple types as function parameters are incorrectly parsed as multiple parameters when generating the function signature. This breaks highlighting for the currently active function parameter.
MWE, generated highlight denoted by
<...>
:Any square brackets are blindly replaced with
_
when generating the signature. This works for array types (e.g.any[]
, which becomesany__
), but breaks when scanning for the next parameter delimiter inside of tuples (e.g.[any, any]
, which becomes_any, any_
). Removing matching brackets via%b[]
instead keeps the same behaviour for array types, but blanks out the entire tuple for tuple types (i.e.[any, any]
becomes__________
).The only potential problem I see with this approach are dictionaries, which may also contain square brackets. These are substituted before attempting to match square brackets however, so this should not cause any issues.