GH-686 Limits on rate-pack values #736
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
I am still uncertain, this will protect the MASQ Foundation network, because if someone want's to set rate-pack below the limit, it is just one change and cargo build away from doing so and network does not even aknowledge this. I woud like to propose: make an debut_handler rule, that if the debuting node is in standard, or originate-only mode, and have rate pack below (or above) the limits, his debut is dropped on the flor
| .expect("Internal error: regex needs four captures") | ||
| .as_str(), | ||
| ) | ||
| .expect("Internal error: regex must require u64") |
There was a problem hiding this comment.
Bug: Regex Capture Error Message Mismatch
The parse_capture function's error message "Internal error: regex needs four captures" is incorrect. The RATE_PACK_LIMIT_FORMAT regex actually has 8 capture groups, not 4. This generic message also makes debugging difficult by not indicating which of the 8 expected fields is missing.
|
Hey @dnwiebe @czarte - I agree with @czarte comments to add this additional checking in the handlers to ensure Nodes don't have rate-packs outside of the defined limits now, and can be done without too much additional work. This will cover older versions of Node joining network with rates outside the hard-coded limits |
No description provided.