-
Notifications
You must be signed in to change notification settings - Fork 40
Add a design document for cached output files #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mark-petersen, as I mentioned in #184, I think we need a design document for this work. Here it is. @matthewhoffman, this work is general enough that it could affect the I will make some additional comments or ask questions in specific sections. |
|
To render the design doc in sphinx, set up the compass environment as usual. Hopefully, you can set it up on your laptops because that makes it easier to open the results in a browser. Once you have sourced the activation script, run: Then, open |
bc4997b to
24fc49f
Compare
24fc49f to
97821e2
Compare
|
@mark-petersen, I believe this is finished but please feel free to commend and request changes. |
mark-petersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar thanks, this looks great. I really like the brief notation of 'c' in
compass setup -n 40c
and then the ability for a longer format with the --cached flag.
I agree that we do not need to require the ability to set up a cached version of every step in a test case. For some domains, like low-resolution regular hexes, it does not make sense to cache the input file.
To be clear, the current implementation does support caching the outputs of every single step of every test case. But I haven't actually run all tests and cached their outputs. So in that sense, we will need to add cache files to the |
|
Thanks very much for the review! I think I'll merge this, and then we can make minor tweaks in #184 if need be. |
This is being implemented in #184