Skip to content

Conversation

@ilesinge
Copy link

Implements #5

@ilesinge ilesinge marked this pull request as ready for review December 12, 2022 18:57
Copy link
Contributor

@Bomme Bomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ilesinge for this PR!

@ffont ffont changed the title Package with Poetry Package for Pypi Dec 19, 2022
@ffont
Copy link
Member

ffont commented Dec 19, 2022

Hi @Bomme @ilesinge , I was to merge that and go ahead with publishing but the workflow for testing the package fails. I tried to fix but I'm a bit confused. Sorry I don't have a lot of experience publishing in pypi, but:

  • The error seems to be related to packages = [{include = "freesound.py"}] not doing its job as it tries also to add the other files (the example and download_bookmarks_example).
  • If we're not using poetry now, why are there references to poetry in pyproject.otml? Is this something to be fixed?

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants