-
-
Notifications
You must be signed in to change notification settings - Fork 137
Update Magic Mirror Server and Client mode documentation #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
updated client mode install instructions
really there's just one install, and then you can run any one of the three environments from there just by changing the command My script is targeted at running full but again all you have to do is change the command to launch the other environments |
maybe i went a bit heavy on the documentation, my approach was with the mindset of what would have helped me figure it out without having to look at any other sources or do any googling. Feel free to edit/amend as needed. |
Can you change the target to the Thanks :) |
done |
* Update weather.md Updated documentation for MetOffice update * Update weather.md
@rejas how are
|
maybe we should merge master regularly back into develop (or everytime master gets some updates) so that this wont happen? |
we should do it everytime master gets some updates, I did it now (with the expected result of merge conflicts in this PR). |
we also need to remove the comment doesn't work over ssh.. as we fixed that a long time ago |
resolved the conflicts and removed the ssh comment. |
Thanks! As already mentioned in the comments above: The So I think the 2 sections beginning with But I'm open to other approaches. |
So should this really be a PR against develop? The intent of this PR when initially submitted was to document running server and client mode based on the way things worked at the time and I guess still will until the next release. Since there is new functionality coming up in the future would it make sense to merge this into master to get current state documented, and setup another PR in develop to update the documentation based on new functionality? Or would it make sense to just close this PR and set up a new one that accounts for functionality changes from scratch. |
I would go for documentation for next release and omit the We can stay on |
@briodan can you update your branch and resolve the conflicts so that we can get this PR into our code? |
there is one install only the start script has a shortcut to not require the word run installers/mm.sh was removed from the MagicMirror package and taken over by my scripted installer |
This PR was written over a year ago to document how client and server mode were working at the time, with the Q4 release that changed the way things work for MM I don't know how much of this PR is still valid and I don't have the cycle to test it. I updated my branch to latest, but beyond that I'll let others take this forward and update the documentation if still required. |
Thanks for your work, Ill take it upon me to finish the PR. Alas, you seem to have worked on your master branch and I cannot push to that it seems :-( |
updating instructions on how to run MagicMirror in server only and client only mode.
fixes #3196