Add stephist with related Stairs plot type, and Volume plot type #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beforerr
changed the title
simeonschaub
added a commit
to simeonschaub/AlgebraOfGraphics.jl
that referenced
this pull request
Jan 21, 2025
and other plot types such as `Scatter`. Possibly an alternative to MakieOrg#572. The only drawback here is that the `visual(...)` needs to come before `histogram()`, otherwise an error is thrown because `width` is not mapped for other plot types. What do you think of this approach?
simeonschaub
added a commit
to simeonschaub/AlgebraOfGraphics.jl
that referenced
this pull request
Jan 30, 2025
and other plot types such as `Scatter`. Possibly an alternative to MakieOrg#572. The only drawback here is that the `visual(...)` needs to come before `histogram()`, otherwise an error is thrown because `width` is not mapped for other plot types. What do you think of this approach?
Author
|
Hi @jkrumbiegel , I am just wondering is there any reason stop us from supporting Volume type? (I can make a separate PR) |
simeonschaub
added a commit
to simeonschaub/AlgebraOfGraphics.jl
that referenced
this pull request
Mar 14, 2025
and other plot types such as `Scatter`. Possibly an alternative to MakieOrg#572. The only drawback here is that the `visual(...)` needs to come before `histogram()`, otherwise an error is thrown because `width` is not mapped for other plot types. What do you think of this approach?
Member
|
No reason, just that Volume wasn't a priority for me personally. But in the long run AoG should support most Makie recipes |
jkrumbiegel
added a commit
that referenced
this pull request
Mar 25, 2025
and other plot types such as `Scatter`. Possibly an alternative to #572. The only drawback here is that the `visual(...)` needs to come before `histogram()`, otherwise an error is thrown because `width` is not mapped for other plot types. What do you think of this approach? --------- Co-authored-by: Julius Krumbiegel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.