update cloud and infra resource pools

[Guddetisandeep]

Dependent PRs for changes in Resource Pool UI, Resource Pool product features and Resource Pool API:

manageiq Core changes PR: ManageIQ/manageiq#23244

manageiq-schema changes PR: ManageIQ/manageiq-schema#764

manageiq-api changes PR: ManageIQ/manageiq-api#1273

manageiq-ui-classic PR: #9303

[miq-bot]

Checked commit Guddetisandeep@5705544 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
38 files checked, 109 offenses detected

app/helpers/application_helper/toolbar/resource_pool_cloud_center.rb

• ❗ - Line 15, Col 113 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 18, Col 3 - Layout/FirstArrayElementIndentation - Indent the right bracket the same as the first position after the preceding left parenthesis.
• ❗ - Line 20, Col 5 - Layout/FirstArrayElementIndentation - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
• ❗ - Line 30, Col 32 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 35, Col 26 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 38, Col 3 - Layout/FirstArrayElementIndentation - Indent the right bracket the same as the first position after the preceding left parenthesis.
• ❗ - Line 3, Col 5 - Layout/FirstArrayElementIndentation - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/resource_pool_clouds_center.rb

• ❗ - Line 20, Col 32 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 23, Col 3 - Layout/FirstArrayElementIndentation - Indent the right bracket the same as the first position after the preceding left parenthesis.
• ❗ - Line 25, Col 5 - Layout/FirstArrayElementIndentation - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
• ❗ - Line 3, Col 5 - Layout/FirstArrayElementIndentation - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
• ❗ - Line 41, Col 32 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 50, Col 32 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 53, Col 3 - Layout/FirstArrayElementIndentation - Indent the right bracket the same as the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/resource_pool_infras_center.rb

• ❗ - Line 20, Col 32 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 23, Col 3 - Layout/FirstArrayElementIndentation - Indent the right bracket the same as the first position after the preceding left parenthesis.
• ❗ - Line 25, Col 5 - Layout/FirstArrayElementIndentation - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
• ❗ - Line 3, Col 5 - Layout/FirstArrayElementIndentation - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
• ❗ - Line 41, Col 32 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 50, Col 32 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 53, Col 3 - Layout/FirstArrayElementIndentation - Indent the right bracket the same as the first position after the preceding left parenthesis.

app/helpers/ems_cloud_helper/textual_summary.rb

• ❗ - Line 135, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 135, Col 44 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 139, Col 33 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.

app/helpers/resource_pool_cloud_helper/textual_summary.rb

• ❗ - Line 101, Col 12 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 102, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 114, Col 11 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 118, Col 101 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 124, Col 11 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 128, Col 101 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 134, Col 11 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 138, Col 101 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 144, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 145, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 150, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 151, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 156, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 157, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 162, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 163, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 168, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 169, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 174, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 175, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 180, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 181, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 186, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 187, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 192, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 193, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 198, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 199, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 204, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 205, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 210, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 211, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 216, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 217, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 46, Col 37 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 51, Col 19 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 51, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 53, Col 41 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 57, Col 19 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 57, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 59, Col 37 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 5, Col 1 - Layout/TrailingWhitespace - Trailing whitespace detected.
• ❗ - Line 63, Col 19 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 63, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 65, Col 38 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 69, Col 19 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 69, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 71, Col 38 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 75, Col 80 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 79, Col 79 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 7, Col 18 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 83, Col 19 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 83, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 84, Col 79 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 88, Col 15 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 89, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

app/helpers/resource_pool_infra_helper/textual_summary.rb

• ❗ - Line 102, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 118, Col 101 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 128, Col 101 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 138, Col 101 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 204, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 205, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 210, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 211, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 216, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 217, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 51, Col 19 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 51, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 57, Col 19 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 57, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 63, Col 19 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 63, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 69, Col 19 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 69, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 83, Col 19 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 83, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 89, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

app/helpers/vm_helper/textual_summary.rb

• ❗ - Line 259, Col 10 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.

app/views/resource_pool_cloud/show.html.haml

• ⚠️ - Line 2 - Line is too long. [97/80]

app/views/resource_pool_infra/_config.html.haml

• ⚠️ - Line 4 - Avoid using instance variables in partials views

app/views/resource_pool_infra/show.html.haml

• ⚠️ - Line 1 - id attribute must be in lisp-case
• ⚠️ - Line 2 - Line is too long. [97/80]
• ⚠️ - Line 3 - Line is too long. [88/80]
• ⚠️ - Line 7 - Line is too long. [81/80]

app/views/resource_pool_infra/show_list.html.haml

• ⚠️ - Line 1 - id attribute must be in lisp-case

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).