Follow up works from #9516 #9546
Conversation
asirvadAbrahamVarghese
changed the title
asirvadAbrahamVarghese
force-pushed
the
edit-collect-logs-form-cypress-refactor
branch
2 times, most recently
from
0e7439e to
f4913f3
Compare
|
PR for intercept-and-wait logic that handles duplicate intercepts: #9552 |
asirvadAbrahamVarghese
force-pushed
the
edit-collect-logs-form-cypress-refactor
branch
from
aff03dc to
b45d49b
Compare
asirvadAbrahamVarghese
force-pushed
the
edit-collect-logs-form-cypress-refactor
branch
from
b45d49b to
1ba688b
Compare
|
@asirvadAbrahamVarghese let me know when this is ready for review and out of WIP |
asirvadAbrahamVarghese
changed the title
| // If the value is not default one(BLANK_VALUE), then setting it to blank | ||
| if (currentValue !== dropdownBlankValue) { | ||
| cy.wrap(selectField).select(dropdownBlankValue); | ||
| cy.getFormFooterButtonByType(saveButton, 'submit').click(); |
There was a problem hiding this comment.
Similar comment to another PR... is saveButton the type and 'submit' the text or vice versa? We might need to rename the function at some point so it's more obvious to naive people like me which is which.
There was a problem hiding this comment.
Continuing the discussion here
There was a problem hiding this comment.
I just want to point out that this set of tests were sporadically failing and slow... It's too early to tell but I think the tests went from 50 seconds to 30 and I don't see any retries after you created and used shared functions that handle the waits on dom elements.
Awesome.
|
Adding spassky for test only changes. No need to diverge from master for these test improvements around sporadic failures and other best practices as we learn. |
|
Backported to |
Use form element selector commands from: Add custom commands for selecting form elements #9537✅Extract shared intercept-and-wait logic that handles duplicate intercepts as recommended Edit collect logs form cypress refactor #9516 (comment)✅Add more detailed component testing if considered required per [WIP] - Added automated tests with cypress for Namespace form #9517✅@miq-bot assign @jrafanie
@miq-bot add-label cypress
@miq-bot add-label test