Enhance form element selectors #9598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsamaryv
approved these changes
Aug 27, 2025
This was referenced Aug 27, 2025
asirvadAbrahamVarghese
force-pushed
the
enhance-form-element-selectors
branch
5 times, most recently
from
45ed3f8 to
d59e2e5
Compare
asirvadAbrahamVarghese
force-pushed
the
enhance-form-element-selectors
branch
from
d59e2e5 to
3b49046
Compare
asirvadAbrahamVarghese
force-pushed
the
enhance-form-element-selectors
branch
from
3b49046 to
84dcf23
Compare
jrafanie
reviewed
Sep 10, 2025
| 'getFormFooterButtonByTypeWithText', | ||
| ({ buttonType = 'button', buttonText } = {}) => { | ||
| if (!buttonText) { | ||
| cy.logAndThrowError('buttonName is required'); |
There was a problem hiding this comment.
As a follow up, we call the function WithText, perhaps buttonText would be a better term to use in the error message.
There was a problem hiding this comment.
Oops...
jrafanie
approved these changes
Sep 10, 2025
This was referenced Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to enhance form elements selector commands to make it more readable as discussed in this thread
input#${inputId}],select#${selectId}]==>input[id="${inputId}"],select[id="${selectId}"].When ids are separated by dots("endpoints.default.hostname"),
input#${inputId}],select#${selectId}]these selectors fail.@miq-bot assign @GilbertCherrie
@miq-bot add-reviewer @elsamaryv
@miq-bot add-label cypress
@miq-bot add-label test
@miq-bot add-label refactoring