Add <map-tile> to support principally GeoServer layer group processing #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up index.html with local geoserver spearfish layer to test map-tile Change getElementsByTagName to querySelectorAll - probably will cause test failures and needs to be thought out and refactored once map-tile is complete WIP on map-tile, TemplatedFeaturesOrTilesLayerGroup, map-link WIP on map-tile, TemplatedFeaturesOrTilesLayerGroup, map-link remove redundant method from TemplatedFeaturesOrTilesLayerGroup WIP on map-tile, TemplatedFeaturesOrTilesLayerGroup, map-link remove redundant method from TemplatedFeaturesOrTilesLayerGroup Comment out CI Hopefully disable CI by temporarily removing ci-testing.yml Add templates parameter to TemplatedFeaturesOrTilesLayerGroup (TFOTLG) Add provisional / draft implementation of moveend handler for TFOTLG, based on simplified version of that from TemplatedFeaturesLayer source Exclude handling of <map-feature> for the moment to get things working incrementally, maybe. Add a hard-coded isVisible() implementation that returns true for the moment Add some code to onAdd and onRemove Layer method overrides Add provisional _setUpTemplateVars function Get rendering of map-tile kinda working. Save some work from today hopefully without breaking stuff Delete MapFeatureLayerGroup.js - only need FeatureLayer.js I hope Keep similar code between map-feature.js and map-tile.js in sync Fix missed isFirst / getPrevious method reconciliation between map-tile and map-feature
it ensures that the FeatureLayer created by templated features has the options._leafletLayer and options._leafletLayer._layerEl props, which are used by DebugOverlay, possibly in not a great way. The question is should the FeatureLayer's features _renderings_ (geometry Leaflet layer) EACH have the layerBounds of the parent map-link OR should they not have bounds that can be used in DebugOverlay.
Improves the rendering time of tiles loaded via <map-link rel="features"...>
Add to do list
…Layer Update ideas in To Do list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeoServer will soon get support for processing layer groups in "vector tile" mode. That is, layers in a layer group referenced by a GetMap request will be able to be represented as vector information, except of course for natural raster layers embedded in the group. These layers will be rendered as sequences of <map-tile row="nnn" col="nnn" zoom="nn" src="GetMap or GetTile URL to an image"></map-tile>.
Currently <map-feature> elements that are found in response to a templated request, whether for an individual tile or for a single untiled GetMap, are added in order of parsing to a templatedFeaturesLayer hosted by the <map-link> that processes them.
This PR should enable a hosted
templatedFeaturesOrTilesLayer(name uncertain) that integrates rendering of both <map-tile> and <map-feature>.The design will evolve in the course of this PR :-)