MDBF-1110 install/upgrade tests in Buildot contain work arounds for fixed bugs #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
These are quite significant changes. Have you had a chance to test them? Otherwise, I’ll need at least half a day to test them on multiple builders. |
This prevents a no-op on ppc64le
MDEV-14622 listed as resolved so remove special handling for spider.
…r package So there's no need for this filter.
Also galera part of package names hasn't existed since 10.1 days.
grooverdan
force-pushed
the
deb-upgrade-cleanup
branch
from
232b7a4 to
528a1c4
Compare
Member
Author
|
not durable enough it seems. |
| BUILDERS_UPGRADE.append(builder_name_autobake + "-major-upgrade") | ||
| BUILDERS_UPGRADE.append(builder_name_autobake + "-distro-upgrade") | ||
|
|
||
| if arch in ["amd64", "aarch64"]: |
Collaborator
There was a problem hiding this comment.
I my understanding correct that columnstore packages are not built for ppc64le as per server configuration?
| package_list=mariadb-server | ||
| ;; | ||
| columnstore) | ||
| get_packages_file_mirror |
Collaborator
There was a problem hiding this comment.
I think this test is useful, if it exists with an error.
Imagine on the server development side or when configuring the buildbot docker environment,
a mistake is made and columnstore packages are no longer generated.
Member
Author
There was a problem hiding this comment.
An error is good. This would have failed with cannot install columnstore at a later step, like any other failure to generate package, that is in the package list below.
| grep 'spider' | awk '{print $2}' | | ||
| sort -u | xargs) | ||
| fi | ||
| if grep -si tokudb Packages; then |
Collaborator
There was a problem hiding this comment.
Might be useful to link the MDEV / commit that removed TokuDB.
Member
Author
There was a problem hiding this comment.
MDEV-19780 Remove the TokuDB storage engine (for 10.6). there was a disable for an earlier version.
scripts/deb-upgrade.sh
Outdated
| all) | ||
| get_packages_file_mirror | ||
| package_list=$(grep "^Package:" Packages | | ||
| grep -vE 'galera' | |
Collaborator
There was a problem hiding this comment.
Might be useful to link MDEV / commit that changed this.
Member
Author
There was a problem hiding this comment.
the package mariadb-galera-server was in 10.0 and 10.1 and 10.2 had the galera "patch" as part of mariadb-server.
I've yet to find a specific MDEV but given it was always going to be EOL with 10.1 I suspect there isn't one.
Collaborator
|
@grooverdan some minor comments, I will schedule a full run on |
Member
Author
Thanks. Would provide a good basis for the columnstore bug if it still exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old bugs are listed as fixed, so lets test them again.
Cleans up columnstore upgrade to the two arches supported.
with the removal of columnstore and spider out of the lists they can be installed like a user normally would.