Fix identifier handling for identifiers with special characters (e.g. org.uat
)
#23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when using the MCP against databases that have special characters in their name, such as
org.uat
, which would cause MCP calls to fail due to "invalid name" errors.According to MariaDB's documentation here, there are particular rules around what constitutes a valid/invalid identifier.
Key Changes
.isidentifier()
with_is_valid_identifier()
method that follows MariaDB identifier rules_normalize_identifier()
as a guard method at all MCP endpoint entry points that:_quote_identifier()
to safely quote identifiers for SQL without double-quotingorg.uat
and`org.uat`
are handled identicallyTesting
Verified this works for databases with special characters. Unable to test vector store endpoints due to missing embedding provider setup.