Skip to content

Conversation

@grooverdan
Copy link
Member

  • The Jira issue number for this PR is: MDBF-801

Description

This enable users that submit pull requests to be able to easily see the link to the full test results of BuildBot.

As @ParadoxV5 commented when prompted about the mistake #4200 fixed, "why do no S390x builders advertise themselves to PRs?". With this, we can make it obvious rather than having users know /remember specific URL patterns.

Release Notes

nothing

How can this PR be tested?

See if the next PR gets a friendly GH comment.

Concept tested by @RazvanLiviuVarzaru
RazvanLiviuVarzaru/buildbot-r#7

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

This enable users that submit pull requests to be able
to easily see the link to the full test results of
BuildBot.
@grooverdan grooverdan requested a review from vuvova July 16, 2025 00:59
@grooverdan grooverdan added the MariaDB Foundation Pull requests created by MariaDB Foundation label Jul 16, 2025
@ParadoxV5
Copy link
Contributor

ParadoxV5 commented Jul 16, 2025

GitHub Action, woah


I’m not fond of letting a bot take over every 1st floor after OP, though, be it a spell checker or even @CLAassistant.
Because GitHub has a dedicated section for those: Checks, where Appveyor and the reported builders are.

@grooverdan
Copy link
Member Author

back to MariaDB/buildbot#743 perhaps

@vuvova
Copy link
Member

vuvova commented Jul 16, 2025

I agree with @ParadoxV5 here. That is, I don't mind when a bot takes over every 1st floor after OP, if needed. But there's a dedicated section in the PR for CI links, and comments aren't where everyone expects a CI link.

@vuvova vuvova closed this Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MariaDB Foundation Pull requests created by MariaDB Foundation

Development

Successfully merging this pull request may close these issues.

3 participants