-
Notifications
You must be signed in to change notification settings - Fork 140
Add info messages for expected errors in test runs #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2702 +/- ##
==========================================
+ Coverage 52.80% 52.84% +0.04%
==========================================
Files 130 130
Lines 7162 7162
Branches 1514 1591 +77
==========================================
+ Hits 3782 3785 +3
+ Misses 3225 3072 -153
- Partials 155 305 +150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
14 tasks
tlylt
requested changes
Apr 17, 2025
| <box type="warning" seamless> | ||
| If you're adding tests that are expected to log errors to the console, make sure to **update the corresponding info messages** in the test logs. |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| If you're adding tests that are expected to log errors to the console, make sure to **update the corresponding info messages** in the test logs. | |
| If you're adding tests that are expected to log new errors to the console, make sure to **update the corresponding info messages** in the test logs. |
tlylt
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Fixes #2612
This PR adds info messages for developers to inform them of the errors they should expect to see during

npm run test. It also updates the developer guide to inform developers of these messages and errors:Anything you'd like to highlight/discuss:
These changes are derived from the PR #2639
Testing instructions:
npm run build:backendnpm run testProposed commit message: (wrap lines at 72 characters)
Add info messages for expected errors in test runs
Currently, there are some error messages that appear during
npm run test. These errors are expected to be logged due to
negative test cases involving includePanelProcessor.test.ts.
These error messages may be confusing to developers, as they may
be unaware that the errors are expected. To fix this, let's add info
messages to inform developers of any expected errors to be seen
during the test run.
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):