remove document symbols from macro expansion #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eg:
#define M \
namespace ns_name \
{ \
namespace ns_name_impl \
{ \
void f() {} \
} \
}
M;
MaskRay
reviewed
May 9, 2021
| @@ -130,6 +130,20 @@ template <> bool ignore(const QueryVar::Def *def) { | |||
| } | |||
| } // namespace | |||
|
|
|||
| bool is_macro_expansion(DB *db, WorkingFile *wf, QueryFile *file, | |||
There was a problem hiding this comment.
This can be folded into ignore for QueryVar::Def
There was a problem hiding this comment.
It's a little bit cumbersome, I'll make a commit, so you can see what it looks like, but we would have to edit all ignore functions not just for QueryVar::Def because we want to ignore all symbols generated by macro expansion not just variables.
rename is_macro_expansion to isPartOfMacroExpansion
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
db890d4 to
cc13ced
Compare
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
e403622 to
cfc7c02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one issue in #674 though that I've completely forgotten about, it does not manage macro expansion eg:
may generate this outline:
clangd is showing symbols in macro definition but not in macro expansion
at least we have to exclude symbols from macro expansion, here is a quick PR to detect and remove macro expansion, but it may exist a better implementation
The question is, what do we do with macro expansions? Should we remove them? (like this PR does)