adapter: default disk limit to MAX in mz_cluster_replica_sizes #33675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that self-managed Materialize is a thing, users can provide their own replica sizes, so it is no longer the case that sizes without resource limits specified can only appear in dev environments. This is especially relevant since self-managed users will have to set their disk limit to either `None` or 0 for swap replica sizes, to avoid engaging the memory limiter. In `mz_cluster_replica_sizes`, we only have non-nullable columns for the resource limits, so we have to pick some value. `u64::MAX` is the most sensible one since it makes it obvious that it is just a placeholder. We were already using it for the CPU and the memory limits, but for the disk limit we were using 1GiB for some reason. This commit changes the placeholder disk limit to `u64::MAX` as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that self-managed Materialize is a thing, users can provide their own replica sizes, so it is no longer the case that sizes without resource limits specified can only appear in dev environments. This is especially relevant since self-managed users will have to set their disk limit to either
Noneor 0 for swap replica sizes, to avoid engaging the memory limiter.In
mz_cluster_replica_sizes, we only have non-nullable columns for the resource limits, so we have to pick some value.u64::MAXis the most sensible one since it makes it obvious that it is just a placeholder. We were already using it for the CPU and the memory limits, but for the disk limit we were using 1GiB for some reason. This PR changes the placeholder disk limit tou64::MAXas well.Motivation
Part of https://github.com/MaterializeInc/database-issues/issues/9692
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.