Skip to content

Update abi_check.py to support standalone tf-psa-crypto #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update abi_check.py to support standalone tf-psa-crypto #229

wants to merge 8 commits into from

Conversation

@bensze01
Copy link
Contributor

@bensze01 bensze01 commented Oct 22, 2025 •
edited
Loading

Description

Move abi_check.py to the framework, and update it to support a standalone tf-psa-crypto

PR checklist

@bensze01 bensze01 added enhancement New feature or request needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon labels Oct 22, 2025
This was referenced Oct 22, 2025
Open
Open
@bensze01
Move abi_check.py to framework
d62bbc4 
Signed-off-by: Bence Szépkúti <[email protected]>
@bensze01
Fix reporting invalid arguments
a741972 
Argparse generally uses a return code of 2 for these situations.

Signed-off-by: Bence Szépkúti <[email protected]>
@bensze01
Revert "Prevent unnecessary submodule fetches"
716f182 
This reverts commit Mbed-TLS/mbedtls@0f2a4f3

The root cause of the issue has been patched in mbedtls-test.

Signed-off-by: Bence Szépkúti <[email protected]>
@bensze01
Remove dead code related to the old crypto submodule
0287b7d 
Signed-off-by: Bence Szépkúti <[email protected]>
@bensze01
Log output of failed subprocesses
5926f58 
Signed-off-by: Bence Szépkúti <[email protected]>
@bensze01
Build library using CMake
ec8c6f8 
Signed-off-by: Bence Szépkúti <[email protected]>
@bensze01
Detect soname clashes
1ecf872 
The same library may be present in the same build tree, eg.
libtfpsacrypto.so, which gets copied from the tf-psa-crypto/core/ to
library/ during an Mbed TLS build.

Make sure that the duplicated libraries are byte-for-byte identical,
otherwise abort the test.

Signed-off-by: Bence Szépkúti <[email protected]>
@bensze01
Allow calling abi_check.py from tf-psa-crypto
7fc3571 
Signed-off-by: Bence Szépkúti <[email protected]>
@bensze01 bensze01 mentioned this pull request Oct 22, 2025
Open
4 tasks
@gilles-peskine-arm
Copy link
Contributor

gilles-peskine-arm commented Oct 22, 2025 •
edited
Loading

abi_check.py has quite a lot of history. Please use David's script to transfer the history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bensze01 @gilles-peskine-arm