Skip to content

Conversation

bjwtaylor
Copy link

@bjwtaylor bjwtaylor commented Jul 10, 2025

Description

Remove support for static ECDH cipher suites, depends Mbed-TLS/TF-PSA-Crypto#377 (merged)
resolves #9201

This PR is part of a chain which needs to be merged in the following order:

  1. Remove support for static ECDH cipher suites mbedtls-framework#182 (merged)
  2. Remove support for static ECDH cipher suites #10294 (this one)

PR checklist

@bjwtaylor bjwtaylor added the needs-ci Needs to pass CI tests label Jul 10, 2025
@bjwtaylor bjwtaylor force-pushed the remove-static-ecdh branch from 375cc45 to 87b15cf Compare July 10, 2025 13:42
@bjwtaylor bjwtaylor added needs-review Every commit must be reviewed by at least two team members, needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Jul 11, 2025
@bjwtaylor bjwtaylor marked this pull request as ready for review July 11, 2025 07:25
@valeriosetti valeriosetti self-requested a review July 15, 2025 11:13
@gilles-peskine-arm gilles-peskine-arm added needs-work size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon and removed needs-review Every commit must be reviewed by at least two team members, needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review labels Jul 15, 2025
@gilles-peskine-arm
Copy link
Contributor

Mbed-TLS/mbedtls-framework#182 is now merged.

@bjwtaylor bjwtaylor mentioned this pull request Jul 16, 2025
4 tasks
@bjwtaylor bjwtaylor force-pushed the remove-static-ecdh branch from d4c04cf to 615dd82 Compare July 16, 2025 13:02
@bjwtaylor bjwtaylor force-pushed the remove-static-ecdh branch 2 times, most recently from 521bd12 to d9e5c71 Compare July 23, 2025 08:24
valeriosetti
valeriosetti previously approved these changes Jul 23, 2025
@bjwtaylor bjwtaylor marked this pull request as draft July 30, 2025 10:04
@bjwtaylor bjwtaylor force-pushed the remove-static-ecdh branch 3 times, most recently from 40aeb7e to a739096 Compare August 4, 2025 10:22
Ben Taylor added 18 commits September 11, 2025 13:22
…ppears it could be causing issues

Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
…CHANGE_PSK_ENABLED

After the ECDH keyexchange removal the two became synonyms so the former can
be removed.

Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-project-automation github-project-automation bot moved this from In Development to Has Approval in Roadmap pull requests (new board) Sep 12, 2025
@mpg mpg added approved Design and code approved - may be waiting for CI or backports and removed needs-work labels Sep 12, 2025
@mpg mpg enabled auto-merge September 12, 2025 08:21
@mpg mpg added this pull request to the merge queue Sep 12, 2025
Merged via the queue into Mbed-TLS:development with commit 0d530d1 Sep 12, 2025
7 of 8 checks passed
@github-project-automation github-project-automation bot moved this from Has Approval to Done in Roadmap pull requests (new board) Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Development

Successfully merging this pull request may close these issues.

Remove static ECDH cipher suites
4 participants