Skip to content

Conversation

valeriosetti
Copy link
Contributor

@valeriosetti valeriosetti commented Jul 30, 2025

Description

Resolves #10266
Depends on:

This is the PR 2 out of 2.

PR checklist

@valeriosetti valeriosetti added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Jul 30, 2025
@valeriosetti valeriosetti changed the title Migrate from mbedtls_pk_can_do_ext to mbedtls_pk_can_do_psa (2/2) [development] Migrate from mbedtls_pk_can_do_ext to mbedtls_pk_can_do_psa (2/2) Jul 30, 2025
@valeriosetti valeriosetti force-pushed the issue10266 branch 6 times, most recently from bd6acde to cccb5b6 Compare August 1, 2025 15:18
@gilles-peskine-arm gilles-peskine-arm self-requested a review August 4, 2025 06:59
@bjwtaylor bjwtaylor self-requested a review September 4, 2025 13:08
@valeriosetti valeriosetti removed the needs-reviewer This PR needs someone to pick it up for review label Sep 4, 2025
@valeriosetti valeriosetti force-pushed the issue10266 branch 3 times, most recently from 500fbe3 to b71ac3c Compare September 12, 2025 13:27
@valeriosetti valeriosetti added needs-reviewer This PR needs someone to pick it up for review and removed needs-preceding-pr Requires another PR to be merged first labels Sep 12, 2025
@gilles-peskine-arm gilles-peskine-arm removed the request for review from bjwtaylor September 12, 2025 15:09
@gilles-peskine-arm gilles-peskine-arm added needs-work and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Sep 12, 2025
@mpg mpg self-requested a review September 16, 2025 08:26
@mpg mpg removed the needs-reviewer This PR needs someone to pick it up for review label Sep 16, 2025
mpg
mpg previously approved these changes Sep 16, 2025
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from In Development to Has Approval in Roadmap pull requests (new board) Sep 16, 2025
@gilles-peskine-arm gilles-peskine-arm added needs-work and removed needs-review Every commit must be reviewed by at least two team members, labels Sep 16, 2025
@gilles-peskine-arm
Copy link
Contributor

Sorry, another submodule update conflict.

When the key is parsed from PK it is assigned the pseudo-alg
MBEDTLS_PK_ALG_ECDSA. Trying to run "mbedtls_pk_can_do_psa" with an hardcoded
deterministc/randomized ECDSA can make the function to fail if the proper
variant is not the one also used by PK.
This commit fixes this problem.

Signed-off-by: Valerio Setti <[email protected]>
Revert changes previously done at following test cases:
- Handshake, select ECDHE-ECDSA-WITH-AES-256-CCM, opaque, PSA_ALG_ANY_HASH
- Handshake, select ECDHE-ECDSA-WITH-AES-256-CCM, opaque, PSA_ALG_SHA_256

Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti valeriosetti dismissed stale reviews from gilles-peskine-arm and mpg via e2aed3a September 16, 2025 14:12
@valeriosetti valeriosetti added needs-review Every commit must be reviewed by at least two team members, and removed needs-work labels Sep 16, 2025
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Sep 16, 2025
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Sep 16, 2025
Merged via the queue into Mbed-TLS:development with commit d66898e Sep 16, 2025
6 of 8 checks passed
@github-project-automation github-project-automation bot moved this from Has Approval to Done in Roadmap pull requests (new board) Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Development

Successfully merging this pull request may close these issues.

Migrate from mbedtls_pk_can_do_ext to mbedtls_pk_can_do_psa
3 participants