-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[development] Migrate from mbedtls_pk_can_do_ext to mbedtls_pk_can_do_psa (2/2) #10333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[development] Migrate from mbedtls_pk_can_do_ext to mbedtls_pk_can_do_psa (2/2) #10333
Conversation
bd6acde
to
cccb5b6
Compare
cccb5b6
to
b43518d
Compare
b43518d
to
49627a6
Compare
500fbe3
to
b71ac3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, another submodule update conflict. |
Signed-off-by: Valerio Setti <[email protected]>
When the key is parsed from PK it is assigned the pseudo-alg MBEDTLS_PK_ALG_ECDSA. Trying to run "mbedtls_pk_can_do_psa" with an hardcoded deterministc/randomized ECDSA can make the function to fail if the proper variant is not the one also used by PK. This commit fixes this problem. Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Revert changes previously done at following test cases: - Handshake, select ECDHE-ECDSA-WITH-AES-256-CCM, opaque, PSA_ALG_ANY_HASH - Handshake, select ECDHE-ECDSA-WITH-AES-256-CCM, opaque, PSA_ALG_SHA_256 Signed-off-by: Valerio Setti <[email protected]>
e2aed3a
20afd7d
to
e2aed3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d66898e
Description
Resolves #10266
Depends on:
This is the PR 2 out of 2.
PR checklist