Skip to content

Conversation

bensze01
Copy link
Contributor

@bensze01 bensze01 commented Aug 18, 2025

Description

Return a const char* instead of taking a char* as an argument.

This aligns us with the interface used in Mbed-TLS/TF-PSA-Crypto#367

Fixes #10308

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog provided
  • development PR provided
  • TF-PSA-Crypto PR not required because: Mbed TLS-only change
  • framework PR not required
  • 3.6 PR not required because: API break
  • tests provided

Return a const char* instead of taking a char* as an argument.

This aligns us with the interface used in TF PSA Crypto.

Signed-off-by: Bence Szépkúti <[email protected]>
@bensze01 bensze01 added enhancement needs-ci Needs to pass CI tests api-break This issue/PR breaks the API and must wait for a new major version priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Aug 18, 2025
@bensze01 bensze01 added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Aug 18, 2025
@bensze01 bensze01 moved this from In Development to In Review in Roadmap pull requests (new board) Aug 18, 2025
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit on the ChangeLog but LGTM otherwise!

@github-project-automation github-project-automation bot moved this from In Review to In Development in Roadmap pull requests (new board) Aug 26, 2025
@bensze01 bensze01 removed the needs-reviewer This PR needs someone to pick it up for review label Aug 27, 2025
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-project-automation github-project-automation bot moved this from In Development to Has Approval in Roadmap pull requests (new board) Aug 27, 2025
@davidhorstmann-arm davidhorstmann-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Aug 27, 2025
@davidhorstmann-arm davidhorstmann-arm added this pull request to the merge queue Aug 27, 2025
Merged via the queue into Mbed-TLS:development with commit 6ff9c89 Aug 27, 2025
5 of 8 checks passed
@github-project-automation github-project-automation bot moved this from Has Approval to Done in Roadmap pull requests (new board) Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break This issue/PR breaks the API and must wait for a new major version approved Design and code approved - may be waiting for CI or backports enhancement priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Development

Successfully merging this pull request may close these issues.

Simplify get-version string interface
3 participants