[Backport 3.6] Move mbedtls_dev to framework submodule
#9131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhorstmann-arm
added
needs-review
davidhorstmann-arm
changed the title
mbedtls_dev to framework submodulembedtls_dev to framework submodule
4 tasks
Signed-off-by: David Horstmann <[email protected]>
This allows test scripts to find the new mbedtls_framework module. Signed-off-by: David Horstmann <[email protected]>
Change these to point to the new mbedtls_framework module in the framework submodule. Signed-off-by: David Horstmann <[email protected]>
This allows scripts in the scripts/ directory to get the path to the mbedtls_framework module in framework/scripts/ Signed-off-by: David Horstmann <[email protected]>
Since this python module resides in the framework submodule we must add an extra explicit path to it for mypy. Signed-off-by: David Horstmann <[email protected]>
This allows us to use the mbedtls_framework python files moved there. Signed-off-by: David Horstmann <[email protected]>
This name is more descriptive of its purpose, since it actually adds framework/scripts to the path rather than just framework/ Signed-off-by: David Horstmann <[email protected]>
davidhorstmann-arm
force-pushed
the
move-mbedtls-dev-to-framework-3.6
branch
from
07b991d to
7f6c81a
Compare
ronald-cron-arm
removed
the
needs-reviewer
Signed-off-by: Ronald Cron <[email protected]>
ronald-cron-arm
approved these changes
May 28, 2024
There was a problem hiding this comment.
LGTM up to the last commit and @davidhorstmann-arm checked the last commit.
bensze01
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial backport of #9094.
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")
mbedtls_devto framework submodule #9094