Skip to content

Conversation

TrishGillett
Copy link
Contributor

@TrishGillett TrishGillett commented Aug 6, 2025

The squirrel girl preview header made the github API provide additional fields, primarily around reactions, for a few endpoints.

However, I suspect it's not doing anything anymore:

  • We're seeing reactions cols populated for IssuesStream, but they are consistently null for PullRequestsStream.
  • The reactions cols are not included in the example responses for either endpoint (issues, pull requests)
  • I found this announcement which isn't as explicit a smoking gun as I would like, but in theory should cover the squirrel girl preview since it existed at the time the announcement was published. ie. either squirrel girl was one of the 23 previews that got promoted, or it was one of the 2 that were intended to be sunset by end of year 2021.
  • My hypothesis is that they did graduate the squirrel girl preview, but only for the issues endpoint.

I'll run some tests like this and confirm that results for both streams are the same whether or not the header is used.

Also to be determined:

  • Should we remove the sunsetted columns from the schema, or keep them there and let them continue to be null to avoid causing disruptions for users?
  • The integer column comments is also unpopulated by the pull requests endpoint in practice and in the example response. It's not clear that it is related to the squirrel girl preview at all, but should it be cleaned up too?

@edgarrmondragon edgarrmondragon self-assigned this Aug 6, 2025
@TrishGillett TrishGillett changed the title Remove defunct squirrel girl beta header Remove defunct squirrel girl preview header Aug 6, 2025
@TrishGillett TrishGillett changed the title Remove defunct squirrel girl preview header refactor: Remove defunct squirrel girl beta header Aug 6, 2025
Copy link

@edgarrmondragon edgarrmondragon removed their assignment Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants