refactor: Remove defunct squirrel girl beta header #439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The squirrel girl preview header made the github API provide additional fields, primarily around reactions, for a few endpoints.
However, I suspect it's not doing anything anymore:
reactions
cols populated for IssuesStream, but they are consistently null for PullRequestsStream.reactions
cols are not included in the example responses for either endpoint (issues, pull requests)I'll run some tests like this and confirm that results for both streams are the same whether or not the header is used.
Also to be determined:
comments
is also unpopulated by the pull requests endpoint in practice and in the example response. It's not clear that it is related to the squirrel girl preview at all, but should it be cleaned up too?