Skip to content

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Sep 24, 2025

Explanation

Currently, we don't have an implicit SLA around Solana account creation, so the account creation process can hang and generally degrade the UX. I've added a new property to the SolAccountProviderConfig, createAccounts, which has a timeoutMs property which can be used to timeout Solana account creation. The default for the creation process is 3 seconds, but this can be configured on a per client basis.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@hmalik88 hmalik88 marked this pull request as ready for review September 24, 2025 00:30
@hmalik88 hmalik88 requested review from a team as code owners September 24, 2025 00:30
cursor[bot]

This comment was marked as outdated.

@montelaidev
Copy link
Contributor

Is there a unit test to test the timeout?

@hmalik88
Copy link
Contributor Author

Is there a unit test to test the timeout?

We have tests for the timeout itself, but good point I'll add a test for the solana provider itself around createAccounts.

@ccharly ccharly changed the title feat: add timeout to Solana account creation feat(multichain-account-service): add timeout to Solana account creation Sep 24, 2025
@ccharly ccharly merged commit a43bf59 into main Sep 24, 2025
239 checks passed
@ccharly ccharly deleted the hm/add-sol-account-creation-timeout branch September 24, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants