fix: migrate to network enablement controller #36150

salimtb · 2025-09-22T08:45:20Z

Description

The goal of this PR is to migrate the network manager to use the NetworkEnablementController from the core repo instead of maintaining a separate local controller.

Why this change?
• Reduces duplication by consolidating network management logic in one place.
• Ensures consistency with the latest implementation in the core repo.
• Makes future updates easier to maintain, since fixes and enhancements to network enablement will flow directly from core.
• Aligns mobile/extension behavior with shared controller patterns.

Changelog

CHANGELOG entry: Refactored network manager to use the NetworkEnablementController from core instead of a local controller.

Related issues

Fixes:

Manual testing steps

Go to network manager
Should have the same behavior
try to add new network through the add, form or dapp
switch network
edit network
delete network

Screenshots/Recordings

Before

After

https://www.loom.com/share/40d0a5d5405f4c93a63eb018f8df1b7e

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-09-22T08:45:30Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-09-22T08:46:41Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/network-enablement-controller@1.2.0

View full report

metamaskbot · 2025-09-22T08:47:49Z

✨ Files requiring CODEOWNER review ✨

🧩 @MetaMask/extension-devs (4 files, +36 -0)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +9 -0
  - 📁 experimental/
    - 📄 policy.json +9 -0
  - 📁 flask/
    - 📄 policy.json +9 -0
  - 📁 main/
    - 📄 policy.json +9 -0

💎 @MetaMask/metamask-assets (1 files, +4 -4)

📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 assets/
      - 📁 asset-list/
        
        📁 asset-list-control-bar/
        
        📄 asset-list-control-bar.tsx +4 -4

📜 @MetaMask/policy-reviewers (4 files, +36 -0)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +9 -0
  - 📁 experimental/
    - 📄 policy.json +9 -0
  - 📁 flask/
    - 📄 policy.json +9 -0
  - 📁 main/
    - 📄 policy.json +9 -0

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

🧪 @MetaMask/qa (2 files, +5 -2)

📁 test/
- 📁 e2e/
  - 📄 default-fixture.js +2 -0
  - 📄 fixture-builder.js +3 -2

🔗 @MetaMask/supply-chain (4 files, +36 -0)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +9 -0
  - 📁 experimental/
    - 📄 policy.json +9 -0
  - 📁 flask/
    - 📄 policy.json +9 -0
  - 📁 main/
    - 📄 policy.json +9 -0

salimtb · 2025-09-22T09:21:45Z

@metamaskbot update-policies

metamaskbot · 2025-09-22T09:37:44Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

salimtb · 2025-09-23T16:44:12Z

@metamaskbot update-policies

metamaskbot · 2025-09-23T16:59:28Z

No policy changes

metamaskbot · 2025-09-23T19:21:34Z

📊 Page Load Benchmark Results

Current Commit: a5d748a | Date: 9/23/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 740ms (±69ms) 🟢 | historical mean value: 742ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	71ms	1.02s	1.32s	1.28s	1.32s
domContentLoaded	740ms	69ms	705ms	1.01s	958ms	1.01s
firstPaint	76ms	11ms	56ms	152ms	88ms	152ms
firstContentfulPaint	76ms	11ms	56ms	152ms	88ms	152ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-23T19:21:42Z

Builds ready [a5d748a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1173 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1173	1056	1319	57	1208	1287
			load	1004	888	1145	53	1042	1092
			domContentLoaded	998	880	1138	53	1035	1087
			domInteractive	17	13	43	6	16	39
			firstPaint	561	137	1142	394	1001	1068
			backgroundConnect	211	198	232	6	213	221
			firstReactRender	25	17	59	6	27	38
			getState	14	5	39	7	17	28
			initialActions	5	0	66	8	6	16
			loadScripts	794	677	923	52	831	879
			setupStore	9	4	26	3	9	17
	Webpack	Home	uiStartup	1142	912	1351	109	1216	1290
			load	963	748	1181	101	1030	1081
			domContentLoaded	958	744	1178	102	1026	1078
			domInteractive	15	12	51	8	14	38
			firstPaint	157	62	443	65	183	252
			backgroundConnect	16	10	48	6	15	28
			firstReactRender	35	32	55	3	35	41
			getState	6	3	16	2	6	11
			initialActions	6	2	14	3	8	11
			loadScripts	955	742	1176	101	1023	1076
			setupStore	8	6	21	3	8	13
Firefox	Browserify	Home	uiStartup	1392	1222	1987	128	1459	1625
			load	1203	1057	1572	86	1278	1325
			domContentLoaded	1202	1057	1572	86	1277	1325
			domInteractive	98	33	275	49	99	233
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	18	125	20	35	92
			firstReactRender	29	23	58	7	29	41
			getState	6	2	60	7	6	12
			initialActions	7	0	206	26	3	13
			loadScripts	1178	1036	1550	84	1251	1300
			setupStore	10	4	89	10	8	25
	Webpack	Home	uiStartup	1596	1383	2057	158	1686	1944
			load	1365	1167	1755	137	1460	1612
			domContentLoaded	1365	1167	1754	137	1459	1611
			domInteractive	107	36	403	63	100	277
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	21	56	8	36	51
			firstReactRender	46	36	64	6	50	58
			getState	6	3	73	7	6	10
			initialActions	3	1	15	2	3	6
			loadScripts	1342	1139	1732	138	1435	1590
			setupStore	11	5	180	20	9	17

Benchmark value 211 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 222 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 233 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 92 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 47 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1944 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 277 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 58 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 254ms | Sum of p95 exceeds: 437.8ms
Sum of all benchmark exceeds: 691.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 9.44 KiB (0.21%)
ui: 1.04 KiB (0.01%)
common: 961 Bytes (0.01%)

metamaskbot · 2025-09-23T19:55:27Z

📊 Page Load Benchmark Results

Current Commit: 67bcd00 | Date: 9/23/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±75ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 741ms (±72ms) 🟢 | historical mean value: 743ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	75ms	1.02s	1.36s	1.30s	1.36s
domContentLoaded	741ms	72ms	702ms	1.04s	969ms	1.04s
firstPaint	76ms	12ms	60ms	172ms	84ms	172ms
firstContentfulPaint	76ms	12ms	60ms	172ms	84ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-23T19:55:35Z

Builds ready [67bcd00]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1171 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1171	1073	1333	58	1205	1270
			load	1004	916	1174	56	1033	1132
			domContentLoaded	998	911	1167	56	1028	1125
			domInteractive	17	13	51	6	16	35
			firstPaint	660	100	1172	400	1016	1077
			backgroundConnect	210	194	239	6	213	222
			firstReactRender	24	18	41	5	25	38
			getState	13	6	44	7	16	26
			initialActions	5	0	75	8	5	16
			loadScripts	794	699	963	55	824	903
			setupStore	9	5	31	4	10	18
	Webpack	Home	uiStartup	1231	979	1452	114	1311	1361
			load	1026	796	1168	106	1101	1141
			domContentLoaded	1020	792	1163	106	1097	1137
			domInteractive	18	13	60	12	15	55
			firstPaint	159	64	437	74	187	314
			backgroundConnect	18	11	42	6	18	33
			firstReactRender	40	36	59	3	40	47
			getState	7	4	18	3	7	14
			initialActions	7	2	26	5	9	16
			loadScripts	1017	790	1160	106	1093	1134
			setupStore	10	7	45	4	10	13
Firefox	Browserify	Home	uiStartup	1481	1296	1973	113	1536	1693
			load	1276	1136	1497	81	1329	1412
			domContentLoaded	1276	1136	1497	81	1329	1411
			domInteractive	109	32	292	52	120	225
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	20	88	13	36	71
			firstReactRender	31	25	61	7	32	46
			getState	7	3	67	8	7	13
			initialActions	3	1	32	4	3	9
			loadScripts	1250	1118	1477	80	1309	1387
			setupStore	12	5	198	21	9	29
	Webpack	Home	uiStartup	1615	1396	2161	155	1711	1929
			load	1379	1181	1814	139	1468	1633
			domContentLoaded	1379	1180	1813	139	1467	1632
			domInteractive	106	33	329	58	105	299
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	21	66	7	36	42
			firstReactRender	47	34	61	5	50	57
			getState	6	3	22	2	6	10
			initialActions	4	1	75	8	3	6
			loadScripts	1356	1156	1777	140	1445	1609
			setupStore	10	5	64	8	10	26

Benchmark value 210 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 222 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 16 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1481 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1277 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1276 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1250 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1693 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 225 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 71 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 47 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 299 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 57 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 419ms | Sum of p95 exceeds: 455.8ms
Sum of all benchmark exceeds: 874.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 9.44 KiB (0.21%)
ui: 1.11 KiB (0.02%)
common: 961 Bytes (0.01%)

metamaskbot · 2025-09-23T21:54:22Z

📊 Page Load Benchmark Results

Current Commit: 37b38a9 | Date: 9/23/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±76ms) 🟡 | historical mean value: 1.06s ⬆️ (historical data)
domContentLoaded-> current mean value: 749ms (±72ms) 🟢 | historical mean value: 742ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	76ms	1.03s	1.36s	1.33s	1.36s
domContentLoaded	749ms	72ms	713ms	1.03s	999ms	1.03s
firstPaint	79ms	11ms	64ms	176ms	88ms	176ms
firstContentfulPaint	79ms	11ms	64ms	176ms	88ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-23T21:54:26Z

Builds ready [37b38a9]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1177 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1177	1053	1343	63	1212	1299
			load	1018	924	1187	60	1057	1140
			domContentLoaded	1012	917	1180	60	1052	1135
			domInteractive	18	13	43	7	17	39
			firstPaint	634	140	1131	401	1016	1087
			backgroundConnect	211	200	282	8	213	220
			firstReactRender	25	19	54	7	27	42
			getState	12	5	62	7	14	25
			initialActions	4	0	14	3	5	11
			loadScripts	807	718	965	58	843	930
			setupStore	9	5	25	3	9	17
	Webpack	Home	uiStartup	1154	919	1335	105	1227	1291
			load	974	758	1160	99	1040	1099
			domContentLoaded	969	754	1155	100	1035	1094
			domInteractive	16	12	48	8	14	38
			firstPaint	156	64	445	56	182	259
			backgroundConnect	16	11	36	7	16	32
			firstReactRender	35	33	51	3	35	42
			getState	6	4	13	2	6	11
			initialActions	6	2	15	4	8	12
			loadScripts	966	752	1153	99	1033	1092
			setupStore	8	6	20	2	8	11
Firefox	Browserify	Home	uiStartup	1433	1235	1763	119	1489	1720
			load	1241	1081	1448	85	1307	1383
			domContentLoaded	1241	1080	1448	85	1306	1383
			domInteractive	104	34	309	49	116	226
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	37	20	150	25	33	100
			firstReactRender	30	23	53	6	31	44
			getState	7	2	79	9	6	17
			initialActions	4	0	77	9	3	10
			loadScripts	1211	1032	1374	80	1272	1355
			setupStore	9	4	44	7	8	25
	Webpack	Home	uiStartup	1743	1484	2115	136	1835	1984
			load	1497	1267	1788	123	1576	1736
			domContentLoaded	1496	1267	1788	123	1575	1736
			domInteractive	116	66	336	58	113	313
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	21	106	12	37	44
			firstReactRender	49	38	63	5	53	58
			getState	7	3	148	14	6	13
			initialActions	4	1	74	8	3	8
			loadScripts	1473	1243	1763	125	1554	1712
			setupStore	10	6	92	9	10	20

Benchmark value 212 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 220 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1433 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1241 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1720 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 226 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 100 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1743 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1497 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1497 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 116 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 49 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1473 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1984 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1736 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1736 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 313 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 58 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1712 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 772ms | Sum of p95 exceeds: 799.8ms
Sum of all benchmark exceeds: 1571.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 9.44 KiB (0.21%)
ui: -3.93 KiB (-0.06%)
common: 162 Bytes (0%)

lavamoat/browserify/beta/policy.json

test/e2e/tests/network/network-manager.spec.ts

ui/components/app/transaction-list/transaction-list.component.js

ui/components/multichain/asset-picker-amount/asset-picker-amount.tsx

ui/components/multichain/network-list-menu/network-list-menu.tsx

Prithpal-Sooriya

Okay changes mostly look good, some comments that need resolving, and we can discuss in a short meeting to validate changes.

metamaskbot · 2025-09-25T13:20:30Z

📊 Page Load Benchmark Results

Current Commit: a1b479a | Date: 9/25/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±71ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 733ms (±82ms) 🟢 | historical mean value: 735ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 86ms (±125ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	71ms	1.00s	1.35s	1.25s	1.35s
domContentLoaded	733ms	82ms	696ms	1.26s	931ms	1.26s
firstPaint	86ms	125ms	56ms	1.32s	88ms	1.32s
firstContentfulPaint	86ms	125ms	56ms	1.32s	88ms	1.32s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-25T13:20:35Z

Builds ready [a1b479a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1253 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1253	1118	1423	69	1306	1373
			load	1084	966	1237	64	1136	1196
			domContentLoaded	1076	959	1228	64	1129	1187
			domInteractive	18	13	51	7	17	39
			firstPaint	687	103	1241	437	1102	1167
			backgroundConnect	256	242	352	12	261	268
			firstReactRender	26	17	87	9	29	39
			getState	15	6	126	14	19	31
			initialActions	5	0	52	6	6	13
			loadScripts	827	714	980	64	881	940
			setupStore	10	6	27	4	11	19
	Webpack	Home	uiStartup	1145	909	1350	106	1224	1287
			load	961	743	1106	99	1036	1093
			domContentLoaded	957	741	1103	99	1032	1085
			domInteractive	16	12	51	8	14	39
			firstPaint	160	61	574	72	181	282
			backgroundConnect	16	10	46	6	15	31
			firstReactRender	35	32	54	3	35	41
			getState	7	4	18	3	7	12
			initialActions	6	2	15	4	8	14
			loadScripts	954	739	1101	98	1029	1083
			setupStore	8	6	20	2	8	12
Firefox	Browserify	Home	uiStartup	1454	1262	1863	117	1529	1689
			load	1248	1099	1498	83	1313	1397
			domContentLoaded	1248	1098	1497	83	1312	1397
			domInteractive	106	34	288	50	108	234
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	19	121	15	38	57
			firstReactRender	29	24	59	5	30	33
			getState	8	2	79	9	7	25
			initialActions	7	1	158	19	5	11
			loadScripts	1222	1078	1471	81	1289	1354
			setupStore	12	5	151	17	10	31
	Webpack	Home	uiStartup	1624	1410	2113	148	1720	1912
			load	1383	1186	1868	139	1482	1618
			domContentLoaded	1383	1185	1867	139	1482	1618
			domInteractive	115	32	331	67	110	301
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	36	20	282	32	37	54
			firstReactRender	38	32	57	4	40	48
			getState	7	3	132	13	7	13
			initialActions	4	1	152	15	4	6
			loadScripts	1355	1152	1767	131	1460	1594
			setupStore	11	6	157	15	10	21

Benchmark value 1254 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1085 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1077 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 257 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1373 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1196 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1188 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 268 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1455 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1248 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1248 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1689 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 234 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1624 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1384 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1383 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 115 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 37 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 301 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 54 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 438ms | Sum of p95 exceeds: 528.8ms
Sum of all benchmark exceeds: 966.8ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 40.34 KiB (0.9%)
ui: 17.95 KiB (0.25%)
common: -92.99 KiB (-1.19%)

ui/components/multichain/network-manager/components/default-networks/default-networks.tsx

metamaskbot · 2025-09-25T15:30:53Z

📊 Page Load Benchmark Results

Current Commit: 60732c9 | Date: 9/25/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±78ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 753ms (±75ms) 🟢 | historical mean value: 739ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	78ms	1.03s	1.39s	1.33s	1.39s
domContentLoaded	753ms	75ms	712ms	1.05s	988ms	1.05s
firstPaint	79ms	11ms	64ms	172ms	88ms	172ms
firstContentfulPaint	79ms	11ms	64ms	172ms	88ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-25T15:30:58Z

Builds ready [60732c9]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1239 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1239	1117	1436	69	1276	1389
			load	1069	963	1257	65	1107	1209
			domContentLoaded	1062	959	1250	64	1099	1201
			domInteractive	19	13	46	8	18	41
			firstPaint	604	78	1266	434	1068	1151
			backgroundConnect	254	239	279	8	259	269
			firstReactRender	26	17	152	14	25	40
			getState	13	5	33	6	16	28
			initialActions	5	0	25	4	6	13
			loadScripts	815	704	1011	65	851	941
			setupStore	9	4	26	3	10	17
	Webpack	Home	uiStartup	1168	921	1435	114	1249	1309
			load	981	755	1245	108	1051	1124
			domContentLoaded	977	752	1242	108	1046	1121
			domInteractive	16	12	51	9	14	41
			firstPaint	153	64	330	57	178	286
			backgroundConnect	16	11	83	9	16	30
			firstReactRender	36	33	45	2	36	41
			getState	6	4	13	2	7	12
			initialActions	7	2	22	4	8	15
			loadScripts	974	750	1239	108	1042	1119
			setupStore	8	6	21	2	8	12
Firefox	Browserify	Home	uiStartup	1422	1242	1922	116	1466	1687
			load	1226	1087	1454	76	1274	1345
			domContentLoaded	1225	1087	1454	76	1274	1345
			domInteractive	107	32	287	53	110	247
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	21	133	16	35	59
			firstReactRender	29	24	74	6	30	36
			getState	8	3	90	10	7	29
			initialActions	5	1	61	6	5	13
			loadScripts	1200	1071	1428	72	1247	1325
			setupStore	13	5	79	15	11	55
	Webpack	Home	uiStartup	1525	1366	2006	146	1615	1811
			load	1289	1139	1608	121	1363	1538
			domContentLoaded	1289	1139	1608	121	1362	1538
			domInteractive	104	36	340	58	102	272
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	19	52	7	36	40
			firstReactRender	36	31	80	5	37	44
			getState	6	3	17	2	6	11
			initialActions	7	0	147	20	4	20
			loadScripts	1267	1121	1590	122	1337	1519
			setupStore	13	6	162	21	10	28

Benchmark value 1240 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1063 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 254 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1390 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1210 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1201 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 269 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 941 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1422 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1687 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 247 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 55 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 272 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 20 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 314ms | Sum of p95 exceeds: 594.8ms
Sum of all benchmark exceeds: 908.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 10.16 KiB (0.22%)
ui: -4.14 KiB (-0.06%)
common: 140 Bytes (0%)

hjetpoluru

e2e files changes lgtm

fix: migrate to network enablement controller

03beba4

metamaskbot added the team-assets label Sep 22, 2025

github-actions bot added the size-XL label Sep 22, 2025

fix: clean up

0fca3b8

Update LavaMoat policies

0287805

fix: clean up

3f8372c

amitabh94 mentioned this pull request Sep 23, 2025

fix: enable networks automatically when added to fix token detection #36102

Closed

7 tasks

salimtb and others added 5 commits September 23, 2025 17:23

Merge branch 'main' into fix/migrate-to-network-enablement

30a1844

fix: clean up

ff2518f

fix: fix linter

139eb7e

Merge branch 'main' into fix/migrate-to-network-enablement

24116e2

fix: fix linter

46e9201

fix : fix e2e tests

a5d748a

fix: clean up

67bcd00

salimtb added 3 commits September 23, 2025 22:20

fix: fix e2e tests

08fde97

fix: clean up

695f056

Merge branch 'main' into fix/migrate-to-network-enablement

37b38a9