feat: Updated pin extension ui cp-13.5.0 #36159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smgv
requested review from
LeVinhGithub,
chaitanyapotti,
himanshuchawla009 and
lionellbriones
smgv
added
area-onboarding
needs-qa
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (1 files, +2 -13)
🔐 @MetaMask/web3auth (12 files, +281 -45)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [4cf4675]
UI Startup Metrics (1198 ± 62 ms)
Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 236 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 77 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 293 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 259ms | Sum of p95 exceeds: 444.8ms Sum of all benchmark exceeds: 703.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/pages/onboarding-flow/onboarding-app-header/onboarding-app-header.js
Outdated
Show resolved
Hide resolved
Contributor
|
Confirmation with Val, QR code + pin screen only for Social Login flow |
Contributor
|
Pls help me check the recording Screenshare.-.2025-09-22.9_23_40.PM.mp4
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [672a124]
UI Startup Metrics (1198 ± 65 ms)
Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 235 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 222 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 103 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1968 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 307 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 251ms | Sum of p95 exceeds: 501.8ms Sum of all benchmark exceeds: 752.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [7291cf8]
UI Startup Metrics (1187 ± 66 ms)
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 227 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1501 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1289 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1289 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 31 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1260 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1824 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 252 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 99 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 297 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 492ms | Sum of p95 exceeds: 656.8ms Sum of all benchmark exceeds: 1148.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
|
Still can click BACK to see the Wallet is ready screen Screenshare.-.2025-09-24.9_44_02.AM.mp4Pls help me check |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Builds ready [7ed6d32]
UI Startup Metrics (1247 ± 68 ms)
Benchmark value 1078 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1070 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 256 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1369 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1183 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 276 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 38 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 25 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 245 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 18 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 217 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 44 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1625 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1388 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1388 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1364 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 296 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 50 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 356ms | Sum of p95 exceeds: 552.8ms Sum of all benchmark exceeds: 908.8ms |
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [6a388a9]
UI Startup Metrics (1232 ± 65 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 261 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2536 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 64 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 353 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1984 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1414 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 227 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 53 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 298 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 289ms | Sum of p95 exceeds: 598.8ms Sum of all benchmark exceeds: 887.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
lwin-kyaw
reviewed
Sep 30, 2025
| await onboardingCompletePage.checkPageIsLoaded(); | ||
| await onboardingCompletePage.checkWalletReadyMessageIsDisplayed(); | ||
| await onboardingCompletePage.completeOnboarding(); | ||
| await onboardingCompletePage.clickCreateWalletDoneButton(); |
Contributor
There was a problem hiding this comment.
nit: it's better to call onboardingCompletePage.completeOnboarding(); instead, under the hood which basically does the same thing.
It would give more useful insight when some one check the tests. 😄
lwin-kyaw
requested changes
Oct 1, 2025
| firstTimeFlowType === FirstTimeFlowType.restore | ||
| ) { | ||
| if (isFireFox || firstTimeFlowType !== FirstTimeFlowType.socialImport) { | ||
| if (isFireFox) { |
Contributor
There was a problem hiding this comment.
The logic here is not correct.
For SRP flow, users should be redirected to the metametrics page regardless of the browser.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [b6b1d09]
UI Startup Metrics (1247 ± 83 ms)
Benchmark value 1081 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1074 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 252 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1419 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1246 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1237 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1189 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 264 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 987 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 22 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2516 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 75 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 265 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 20 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1442 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1245 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1667 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 244 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1940 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 313 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 371ms | Sum of p95 exceeds: 886.8ms Sum of all benchmark exceeds: 1257.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| ? ONBOARDING_COMPLETION_ROUTE | ||
| : ONBOARDING_METAMETRICS, | ||
| { replace: true }, | ||
| ); |
There was a problem hiding this comment.
Bug: Social Import Flow Redirects Incorrectly
Removing FirstTimeFlowType.socialImport from the initial navigation condition causes social import users to incorrectly fall through the logic and navigate to ONBOARDING_REVIEW_SRP_ROUTE. The intended behavior for social import flows is to skip additional onboarding steps and proceed directly to completion.
Collaborator
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [0604efa]
UI Startup Metrics (1209 ± 66 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 272 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 35 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 22 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 37 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2479 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 72 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 282 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1423 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1691 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 226 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 292 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 309ms | Sum of p95 exceeds: 619.8ms Sum of all benchmark exceeds: 928.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chloeYue
approved these changes
Oct 1, 2025
metamaskbot
added
the
release-13.5.0
smgv
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the following:
Jira Link: https://consensyssoftware.atlassian.net/browse/SL-53
Figma Link: https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding?node-id=16495-182029&m=dev
Changelog
CHANGELOG entry: Updated pin extension ui
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
SOCIAL LOGIN FLOW:
Screen.Recording.2025-09-25.at.8.17.53.AM.mov
SRP FLOW:
Screen.Recording.2025-09-25.at.8.18.48.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Reworks onboarding to show Download App before completion, replaces the pin-extension carousel with a header banner, auto-completes onboarding to Home, and updates tests and copy.
ONBOARDING_DOWNLOAD_APP_ROUTE; Download App Continue now routes toONBOARDING_COMPLETION_ROUTE.setCompletedOnboarding), tracksExtensionPinned, and navigates toDEFAULT_ROUTE.replace.ONBOARDING_COMPLETION_ROUTEwith guidance to pin MetaMask; includes new styles.downloadAppDescriptioncopy and text color.pinMetaMaskandpinMetaMaskDescription; updatesdownloadAppDescriptioninapp/_locales/en*.OnboardingCompletePage.completeOnboarding().Written by Cursor Bugbot for commit 0604efa. This will update automatically on new commits. Configure here.