feat: update subscription check out url handling #36161

tuna1207 · 2025-09-22T11:16:44Z

Description

Previously we were using extension identity API's launchWebAuthFlow for handling subscription checkout url which should have been used for oauth only and will open a controlled window which doesn't support other extension.
This PR open new tab to handle checkout with check for success url redirect instead from both popup and full screen mode.

Changelog

CHANGELOG entry: Subscription check out URL open new tab

Related issues

Fixes:

Manual testing steps

Go to #shield-plan page
Start subscription check out

Screenshots/Recordings

Before

After

Screen.Recording.2025-09-22.at.17.12.45.mov

Screen.Recording.2025-09-22.at.17.11.14.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

- change contents based on payment method - show usdt usdc and musd only with balance

- add todo on shield plan and type

metamaskbot · 2025-09-24T02:32:18Z

Builds ready [2f7b8ec]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1239 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1239	1108	1368	58	1278	1322
			load	1068	929	1190	57	1104	1155
			domContentLoaded	1060	920	1183	57	1099	1141
			domInteractive	19	13	103	11	17	40
			firstPaint	668	142	1168	428	1079	1140
			backgroundConnect	251	236	270	7	255	263
			firstReactRender	27	15	132	13	32	43
			getState	16	5	88	11	17	40
			initialActions	5	0	25	4	7	14
			loadScripts	817	673	934	56	852	896
			setupStore	10	6	27	4	12	19
	Webpack	Home	uiStartup	1093	916	1390	94	1142	1289
			load	902	748	1150	84	956	1032
			domContentLoaded	897	745	1146	83	953	1028
			domInteractive	16	12	56	8	14	33
			firstPaint	163	65	566	69	187	246
			backgroundConnect	19	11	60	11	19	46
			firstReactRender	37	33	77	7	36	47
			getState	7	4	20	3	10	15
			initialActions	6	2	16	4	10	14
			loadScripts	894	743	1144	82	950	1018
			setupStore	9	6	22	2	9	13
Firefox	Browserify	Home	uiStartup	1414	1250	1966	107	1475	1594
			load	1221	1094	1431	74	1276	1370
			domContentLoaded	1221	1093	1430	74	1276	1370
			domInteractive	107	35	316	55	110	263
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	38	20	133	23	37	104
			firstReactRender	29	24	55	6	29	46
			getState	8	3	97	17	6	42
			initialActions	5	1	186	20	3	6
			loadScripts	1192	1075	1384	71	1248	1331
			setupStore	11	5	198	21	8	20
	Webpack	Home	uiStartup	1573	1404	2193	153	1646	1910
			load	1345	1187	1700	127	1434	1610
			domContentLoaded	1345	1187	1700	127	1434	1610
			domInteractive	106	32	343	67	100	290
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	22	59	7	37	46
			firstReactRender	44	38	55	4	46	52
			getState	8	2	165	22	6	13
			initialActions	3	1	21	2	3	6
			loadScripts	1322	1163	1668	127	1407	1580
			setupStore	11	6	107	14	9	22

Benchmark value 1240 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 252 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 263 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 40 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1414 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 38 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 263 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 104 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 42 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 6 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 290 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 314ms | Sum of p95 exceeds: 537.8ms
Sum of all benchmark exceeds: 851.8ms

metamaskbot · 2025-09-24T02:43:14Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-09-24T03:09:39Z

📊 Page Load Benchmark Results

Current Commit: 7604111 | Date: 9/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±69ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 728ms (±68ms) 🟢 | historical mean value: 742ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±14ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	69ms	1.01s	1.31s	1.27s	1.31s
domContentLoaded	728ms	68ms	697ms	992ms	943ms	992ms
firstPaint	75ms	14ms	56ms	200ms	84ms	200ms
firstContentfulPaint	75ms	14ms	56ms	200ms	84ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-24T03:09:46Z

Builds ready [7604111]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1242 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1242	1106	1416	69	1288	1380
			load	1072	958	1234	66	1112	1205
			domContentLoaded	1065	939	1226	66	1105	1192
			domInteractive	18	14	44	7	17	39
			firstPaint	713	70	1244	432	1082	1201
			backgroundConnect	249	235	269	7	253	262
			firstReactRender	24	17	41	5	25	38
			getState	14	5	83	10	16	31
			initialActions	4	1	35	4	5	13
			loadScripts	823	706	983	65	857	949
			setupStore	9	6	22	3	11	17
	Webpack	Home	uiStartup	1100	911	1776	119	1148	1277
			load	910	745	1524	109	973	1042
			domContentLoaded	905	741	1511	108	966	1038
			domInteractive	16	12	54	9	14	43
			firstPaint	158	63	447	68	186	277
			backgroundConnect	17	10	48	8	15	39
			firstReactRender	36	33	62	4	37	44
			getState	8	4	23	4	10	16
			initialActions	7	2	44	6	10	16
			loadScripts	902	739	1502	107	962	1029
			setupStore	9	6	17	2	9	12
Firefox	Browserify	Home	uiStartup	1378	1230	1750	94	1420	1588
			load	1198	1082	1423	74	1242	1330
			domContentLoaded	1197	1082	1423	74	1241	1330
			domInteractive	105	35	307	51	112	247
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	21	108	13	33	48
			firstReactRender	28	23	65	6	28	39
			getState	5	2	9	2	6	8
			initialActions	4	0	151	16	3	6
			loadScripts	1174	1065	1395	72	1222	1302
			setupStore	9	5	51	7	8	18
	Webpack	Home	uiStartup	1680	1447	2084	147	1766	1989
			load	1432	1221	1792	132	1515	1709
			domContentLoaded	1432	1221	1792	132	1515	1709
			domInteractive	114	37	299	56	107	292
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	22	66	8	39	46
			firstReactRender	49	39	75	6	52	62
			getState	7	3	144	14	6	11
			initialActions	3	1	22	3	4	8
			loadScripts	1407	1196	1762	133	1491	1687
			setupStore	10	6	33	4	11	22

Benchmark value 1243 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1073 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1065 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 249 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1380 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1205 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1192 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1201 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 949 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 16 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 247 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 6 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1680 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1433 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1432 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 49 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1408 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1989 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1709 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1709 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 292 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1687 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 528ms | Sum of p95 exceeds: 755.8ms
Sum of all benchmark exceeds: 1283.8ms

lavamoat/browserify/beta/policy.json

lavamoat/browserify/experimental/policy.json

lavamoat/browserify/flask/policy.json

lavamoat/browserify/main/policy.json

github-actions · 2025-09-24T14:40:55Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-09-24T15:06:24Z

📊 Page Load Benchmark Results

Current Commit: 44f461f | Date: 9/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.08s (±74ms) 🟡 | historical mean value: 1.06s ⬆️ (historical data)
domContentLoaded-> current mean value: 754ms (±70ms) 🟢 | historical mean value: 744ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±14ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.08s	74ms	1.02s	1.37s	1.30s	1.37s
domContentLoaded	754ms	70ms	707ms	1.04s	963ms	1.04s
firstPaint	81ms	14ms	60ms	204ms	92ms	204ms
firstContentfulPaint	81ms	14ms	60ms	204ms	92ms	204ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-24T15:06:35Z

Builds ready [44f461f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1228 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1228	1107	1433	65	1265	1348
			load	1054	908	1242	61	1092	1147
			domContentLoaded	1047	899	1235	61	1085	1141
			domInteractive	18	13	45	6	17	34
			firstPaint	593	92	1225	429	1067	1137
			backgroundConnect	220	205	304	11	224	236
			firstReactRender	27	17	71	7	29	41
			getState	13	5	42	7	16	30
			initialActions	6	0	61	8	7	16
			loadScripts	834	689	1018	57	870	923
			setupStore	10	6	23	3	11	18
	Webpack	Home	uiStartup	1163	927	1324	106	1241	1299
			load	976	760	1129	99	1051	1103
			domContentLoaded	971	757	1124	100	1046	1099
			domInteractive	16	12	49	9	14	42
			firstPaint	151	64	350	56	176	258
			backgroundConnect	16	9	41	6	15	30
			firstReactRender	36	33	50	3	37	43
			getState	6	4	20	3	6	13
			initialActions	7	2	20	4	8	15
			loadScripts	968	755	1122	99	1041	1096
			setupStore	9	6	19	2	9	13
Firefox	Browserify	Home	uiStartup	1365	1219	1775	86	1422	1500
			load	1188	1064	1443	67	1236	1294
			domContentLoaded	1188	1064	1443	67	1236	1293
			domInteractive	92	34	184	28	108	154
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	19	91	10	31	44
			firstReactRender	27	22	46	4	29	35
			getState	7	3	92	13	6	9
			initialActions	3	1	9	1	4	5
			loadScripts	1166	1043	1418	66	1212	1273
			setupStore	9	4	88	12	8	15
	Webpack	Home	uiStartup	1613	1404	2284	169	1723	1931
			load	1372	1157	1720	143	1495	1650
			domContentLoaded	1372	1156	1720	143	1495	1650
			domInteractive	112	32	333	68	110	303
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	21	162	16	37	41
			firstReactRender	47	39	61	5	50	55
			getState	7	2	84	8	7	10
			initialActions	4	1	60	6	4	7
			loadScripts	1347	1137	1702	143	1453	1622
			setupStore	13	5	221	22	10	22

Benchmark value 221 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 834 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 236 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 5 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 47 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 303 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 265ms | Sum of p95 exceeds: 401.8ms
Sum of all benchmark exceeds: 666.8ms

cursor · 2025-09-24T15:34:34Z

app/scripts/metamask-controller.js

+            checkoutSucceeded = true;
+
+            // Clean up: close the tab
+            this.platform.closeTab(tabId);


Bug

The startSubscriptionWithCard method calls this.platform.closeTab(tabId) without awaiting its async operation or handling potential rejections. If closeTab fails to close the tab, the onTabRemovedListener won't trigger, causing the checkout Promise to hang indefinitely and leaving event listeners active.

metamaskbot · 2025-09-24T15:54:03Z

📊 Page Load Benchmark Results

Current Commit: 229db31 | Date: 9/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±74ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 742ms (±71ms) 🟢 | historical mean value: 743ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±14ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	74ms	1.01s	1.35s	1.27s	1.35s
domContentLoaded	742ms	71ms	701ms	1.03s	944ms	1.03s
firstPaint	79ms	14ms	60ms	204ms	92ms	204ms
firstContentfulPaint	79ms	14ms	60ms	204ms	92ms	204ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-24T15:54:18Z

Builds ready [229db31]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1224 ± 76 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1224	1093	1461	76	1271	1377
			load	1053	939	1310	72	1088	1208
			domContentLoaded	1047	932	1305	72	1077	1203
			domInteractive	18	14	51	7	17	43
			firstPaint	624	81	1254	428	1061	1128
			backgroundConnect	215	202	233	6	219	226
			firstReactRender	25	18	45	6	27	36
			getState	13	5	47	7	16	27
			initialActions	6	0	95	11	6	14
			loadScripts	838	721	1103	72	871	984
			setupStore	9	4	18	2	10	14
	Webpack	Home	uiStartup	1171	929	1442	113	1251	1319
			load	986	763	1167	106	1059	1131
			domContentLoaded	981	759	1163	106	1054	1128
			domInteractive	16	12	56	10	14	51
			firstPaint	166	66	427	61	192	276
			backgroundConnect	16	10	35	6	14	29
			firstReactRender	36	33	78	5	36	42
			getState	6	4	23	3	7	12
			initialActions	6	2	22	5	8	19
			loadScripts	978	757	1161	106	1051	1126
			setupStore	8	6	19	2	9	14
Firefox	Browserify	Home	uiStartup	1385	1216	1901	129	1431	1631
			load	1193	1063	1435	84	1261	1332
			domContentLoaded	1193	1062	1435	84	1260	1332
			domInteractive	101	31	370	57	95	237
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	19	161	19	32	68
			firstReactRender	28	23	45	5	30	39
			getState	11	3	253	32	6	18
			initialActions	6	1	73	11	4	13
			loadScripts	1171	1045	1398	81	1239	1311
			setupStore	9	5	47	6	8	25
	Webpack	Home	uiStartup	1541	1371	2067	138	1638	1825
			load	1313	1171	1668	108	1399	1532
			domContentLoaded	1313	1170	1668	108	1399	1532
			domInteractive	95	32	261	41	104	188
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	20	240	23	34	40
			firstReactRender	42	35	74	6	45	51
			getState	7	3	115	11	7	13
			initialActions	5	0	138	16	4	7
			loadScripts	1291	1150	1638	108	1364	1512
			setupStore	10	5	65	8	9	21

Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 838 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1377 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1208 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1203 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 227 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 985 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 19 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 237 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 188 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 256ms | Sum of p95 exceeds: 424.8ms
Sum of all benchmark exceeds: 680.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 468 Bytes (0.01%)
ui: 0 Bytes (0%)
common: 354 Bytes (0%)

lionellbriones

lgtm

lionellbriones and others added 30 commits August 22, 2025 17:08

feat: added shield plan UI

7b6ad10

feat: updated font size

af2361a

feat: add save badge, custom token list and confirmation style UI

1e12eb8

feat: added locales

9b04558

feat: fix states

a65959b

feat: added shield payment modal tests

94de6a5

feat: add shield plan test

b1682cb

Merge branch 'main' into feat/shield-plan

24fa9ef

feat: filter stable coins

9e965cb

- change contents based on payment method - show usdt usdc and musd only with balance

Merge branch 'main' into feat/shield-plan

2f2c0f1

Merge branch 'main' into feat/shield-plan

e11a3cd

feat: fix lint and unit tests

8dfd009

feat: fix lint and null selected asset

357b5e1

fix: test lint

38b7f25

fix: removed unused codes

c12c694

fix: issue on token list generator

3cc3139

feat: update code owner

c986aea

feat: remove code owners

d991948

- add todo on shield plan and type

Merge branch 'main' into feat/shield-plan

7f29c2a

feat: fix messages lint

4fcb2e8

feat: add loader

6d196b4

feat: subscription controller init

0446205

feat: expose subscription api

4e205ce

feat: handle shield payment plan tokens

8729e79

fix: correct pricing hook

303655b

feat: update actions

a5a5fc4

feat: shield plan subscription data

da1e06f

feat: handle controller method

3c7537a

feat: update shield screen integration

2ed847d

feat: update billing display

2a65c8f

Update LavaMoat policies

7604111

tuna1207 commented Sep 24, 2025

View reviewed changes

Base automatically changed from feat/subscription-shield-settings-integration to main September 24, 2025 14:33

Merge branch 'main' into feat/checkout-url-handling

44f461f

tuna1207 marked this pull request as ready for review September 24, 2025 15:01

tuna1207 requested review from lionellbriones and lwin-kyaw September 24, 2025 15:01

This comment was marked as outdated.

Sign in to view

chaitanyapotti approved these changes Sep 24, 2025

View reviewed changes

lwin-kyaw approved these changes Sep 24, 2025

View reviewed changes

chaitanyapotti enabled auto-merge September 24, 2025 15:25

chaitanyapotti removed the request for review from lionellbriones September 24, 2025 15:26

Merge branch 'main' into feat/checkout-url-handling

229db31

cursor bot reviewed Sep 24, 2025

View reviewed changes

lionellbriones approved these changes Sep 24, 2025

View reviewed changes

chaitanyapotti added this pull request to the merge queue Sep 25, 2025

Merged via the queue into main with commit f258651 Sep 25, 2025
149 checks passed

chaitanyapotti deleted the feat/checkout-url-handling branch September 25, 2025 03:07

github-actions bot locked and limited conversation to collaborators Sep 25, 2025

metamaskbot added the release-13.5.0 Issue or pull request that will be included in release 13.5.0 label Sep 25, 2025

feat: update subscription check out url handling #36161

feat: update subscription check out url handling #36161

Conversation

tuna1207 commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

metamaskbot commented Sep 24, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

metamaskbot commented Sep 24, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot Sep 24, 2025

Choose a reason for hiding this comment

Bug

Uh oh!

metamaskbot commented Sep 24, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 24, 2025

Uh oh!

lionellbriones left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tuna1207 commented Sep 22, 2025 •

edited

Loading