Skip to content

Conversation

AugmentedMode
Copy link
Contributor

@AugmentedMode AugmentedMode commented Sep 22, 2025

Description

This PR fixes a regression where internal wallet accounts were incorrectly flagged as suspicious by the trust signal system when sending transactions. The issue was that trust signal checks were being applied to internal accounts, causing false alerts when transferring between accounts owned by the user (or to the same account).

The solution introduces a check to skip trust signal evaluation for internal accounts.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Fixed a bug where internal wallet accounts were incorrectly flagged as suspicious when sending transactions.

Related issues

Fixes: #36133

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@AugmentedMode AugmentedMode requested a review from a team as a code owner September 22, 2025 13:25
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-product-safety Push issues to Product Safety team label Sep 22, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Sep 22, 2025

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (1 files, +13 -1)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 hooks/
          • 📁 alerts/
            • 📄 useAddressTrustSignalAlerts.ts +13 -1

@AugmentedMode AugmentedMode self-assigned this Sep 22, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 6f917f5 | Date: 9/22/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.08s (±75ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 759ms (±72ms) 🟢 | historical mean value: 736ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±12ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.08s 75ms 1.03s 1.38s 1.30s 1.38s
domContentLoaded 759ms 72ms 717ms 1.05s 971ms 1.05s
firstPaint 80ms 12ms 60ms 180ms 92ms 180ms
firstContentfulPaint 80ms 12ms 60ms 180ms 92ms 180ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [6f917f5]
UI Startup Metrics (1174 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1174105514556612191289
load101191212356010521116
domContentLoaded100390612226010471107
domInteractive17134871638
firstPaint62984122840210251097
backgroundConnect2091952346211219
firstReactRender24165162836
getState1453361625
initialActions60537714
loadScripts802693101860843907
setupStore963031015
WebpackHomeuiStartup1112899148210911841271
load930740119210710061076
domContentLoaded925736118710710011066
domInteractive15125881334
firstPaint1576272486175264
backgroundConnect16103561731
firstReactRender3732115143548
getState74203813
initialActions62244815
loadScripts92273411781069981064
setupStore86142912
FirefoxBrowserifyHomeuiStartup14321242182611915191641
load1240108116269413081379
domContentLoaded1240108116269413081379
domInteractive1093246960119220
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3320177203356
firstReactRender29247672942
getState72719712
initialActions41588321
loadScripts1215105916069212871351
setupStore95467927
WebpackHomeuiStartup16231406205914417311896
load13861184168012414771573
domContentLoaded13861184168012414761573
domInteractive1043231153101277
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect31235473643
firstReactRender47336654957
getState73636713
initialActions3012237
loadScripts13641165166012514551550
setupStore116116141030
Benchmark value 209 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 220 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1433 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1240 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 220 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 21 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1624 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1387 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1386 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 47 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1364 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 277 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 57 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 299ms | Sum of p95 exceeds: 401.8ms
Sum of all benchmark exceeds: 700.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 224 Bytes (0%)
  • common: 10 Bytes (0%)

@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-S team-product-safety Push issues to Product Safety team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Suspicious address alert when sending from one account to another, on Linea Network

2 participants