fix: solana account switching #36168

montelaidev · 2025-09-22T13:29:22Z

Description

This PR fixes the issue where switching accounts when connected to solana dapps does not trigger the metamask_accountsChanged notification.

Changelog

CHANGELOG entry: fixes account switching for solana dapps.

Related issues

Manual testing steps

Go to jup.ag
Connect multiple accounts
Go to the wallet and change accounts
See that on jup.ag, the selected solana account has switched.

Screenshots/Recordings

Before

After

The connect modal will be resolved in #36064

Screen.Recording.2025-09-22.at.21.28.31.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-09-22T13:29:43Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-09-22T13:55:10Z

📊 Page Load Benchmark Results

Current Commit: 1516b28 | Date: 9/22/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±74ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 740ms (±71ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±13ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	74ms	1.02s	1.33s	1.32s	1.33s
domContentLoaded	740ms	71ms	706ms	1.01s	988ms	1.01s
firstPaint	75ms	13ms	56ms	184ms	88ms	184ms
firstContentfulPaint	75ms	13ms	56ms	184ms	88ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-22T13:55:22Z

Builds ready [1516b28]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1188 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1188	1075	1406	62	1231	1280
			load	1025	923	1232	59	1056	1137
			domContentLoaded	1017	916	1209	58	1048	1130
			domInteractive	17	13	51	7	17	37
			firstPaint	640	70	1202	409	1038	1097
			backgroundConnect	211	202	235	6	213	224
			firstReactRender	26	18	41	6	29	38
			getState	13	5	50	7	16	28
			initialActions	5	0	43	6	6	18
			loadScripts	813	707	1002	58	844	928
			setupStore	10	4	24	4	12	17
	Webpack	Home	uiStartup	1158	922	1446	112	1234	1314
			load	976	758	1168	106	1046	1108
			domContentLoaded	971	754	1160	106	1041	1105
			domInteractive	16	12	64	9	14	42
			firstPaint	165	64	413	69	206	300
			backgroundConnect	17	12	36	6	18	30
			firstReactRender	35	33	45	2	35	41
			getState	7	4	19	3	7	12
			initialActions	6	2	20	4	8	15
			loadScripts	968	752	1148	105	1037	1103
			setupStore	8	6	19	2	9	12
Firefox	Browserify	Home	uiStartup	1385	1177	1812	107	1447	1581
			load	1199	1036	1437	75	1266	1327
			domContentLoaded	1198	1036	1437	75	1265	1326
			domInteractive	106	32	281	52	115	239
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	19	129	19	33	65
			firstReactRender	29	23	69	7	30	42
			getState	6	2	77	8	6	12
			initialActions	7	1	194	27	3	11
			loadScripts	1174	1018	1419	73	1221	1292
			setupStore	10	4	97	12	8	31
	Webpack	Home	uiStartup	1545	1337	2170	182	1596	2040
			load	1316	1154	1744	136	1384	1621
			domContentLoaded	1316	1154	1743	136	1384	1621
			domInteractive	106	33	401	71	97	304
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	19	50	7	35	42
			firstReactRender	44	36	85	6	46	51
			getState	6	3	20	2	6	10
			initialActions	6	1	206	24	3	7
			loadScripts	1293	1134	1720	137	1365	1599
			setupStore	11	6	82	12	9	23

Benchmark value 212 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 224 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 239 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 2040 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 304 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 252ms | Sum of p95 exceeds: 546.8ms
Sum of all benchmark exceeds: 798.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.17 KiB (0.03%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-09-22T14:31:42Z

📊 Page Load Benchmark Results

Current Commit: 60abe5d | Date: 9/22/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±73ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 745ms (±69ms) 🟢 | historical mean value: 736ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	73ms	1.02s	1.34s	1.32s	1.34s
domContentLoaded	745ms	69ms	708ms	1.01s	984ms	1.01s
firstPaint	79ms	11ms	64ms	180ms	88ms	180ms
firstContentfulPaint	79ms	11ms	64ms	180ms	88ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-22T14:31:49Z

Builds ready [60abe5d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1177 ± 54 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1177	1065	1362	54	1212	1262
			load	1011	929	1155	47	1046	1080
			domContentLoaded	1004	924	1147	47	1039	1073
			domInteractive	18	13	50	8	17	41
			firstPaint	655	145	1153	400	1022	1080
			backgroundConnect	212	200	236	6	214	227
			firstReactRender	25	18	46	6	26	37
			getState	13	5	37	6	18	25
			initialActions	4	1	18	3	5	12
			loadScripts	798	695	934	47	832	872
			setupStore	9	5	21	3	10	14
	Webpack	Home	uiStartup	1189	951	1410	112	1268	1337
			load	1000	775	1221	107	1072	1130
			domContentLoaded	994	771	1214	107	1066	1124
			domInteractive	16	13	43	6	15	35
			firstPaint	155	65	327	59	178	290
			backgroundConnect	17	12	37	6	16	32
			firstReactRender	37	34	45	2	37	43
			getState	7	4	19	3	7	12
			initialActions	6	2	21	4	8	13
			loadScripts	991	768	1211	107	1063	1121
			setupStore	8	6	22	2	9	13
Firefox	Browserify	Home	uiStartup	1376	1200	1740	105	1442	1555
			load	1193	1061	1378	77	1260	1324
			domContentLoaded	1192	1061	1376	76	1260	1324
			domInteractive	100	32	298	52	100	237
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	18	104	18	34	87
			firstReactRender	28	23	69	6	29	39
			getState	8	3	87	15	6	57
			initialActions	5	0	200	20	3	11
			loadScripts	1168	1032	1349	76	1239	1303
			setupStore	10	5	109	14	8	31
	Webpack	Home	uiStartup	1599	1381	2089	162	1711	1903
			load	1369	1164	1691	145	1488	1627
			domContentLoaded	1369	1164	1691	145	1488	1627
			domInteractive	109	33	336	65	100	311
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	20	53	6	35	40
			firstReactRender	45	36	58	5	48	54
			getState	6	3	15	2	6	8
			initialActions	4	0	135	13	3	5
			loadScripts	1347	1146	1670	146	1469	1601
			setupStore	9	6	29	4	10	16

Benchmark value 213 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 227 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 237 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 87 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 57 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 311 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 5 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 250ms | Sum of p95 exceeds: 492.8ms
Sum of all benchmark exceeds: 742.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 844 Bytes (0.02%)
ui: 1.05 KiB (0.01%)
common: 11 Bytes (0%)

metamaskbot · 2025-09-22T15:14:21Z

📊 Page Load Benchmark Results

Current Commit: bb1bc1a | Date: 9/22/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 736ms (±68ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±15ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	71ms	1.02s	1.31s	1.27s	1.31s
domContentLoaded	736ms	68ms	704ms	1.00s	940ms	1.00s
firstPaint	76ms	15ms	60ms	208ms	88ms	208ms
firstContentfulPaint	76ms	15ms	60ms	208ms	88ms	208ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-22T15:14:36Z

Builds ready [bb1bc1a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1206 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1206	1097	1473	57	1235	1298
			load	1032	915	1171	49	1063	1116
			domContentLoaded	1024	903	1165	50	1056	1110
			domInteractive	18	14	45	6	17	36
			firstPaint	689	150	1179	407	1053	1101
			backgroundConnect	215	203	237	6	217	225
			firstReactRender	27	18	120	13	29	47
			getState	14	5	100	11	17	34
			initialActions	7	1	82	13	6	16
			loadScripts	817	696	957	49	848	900
			setupStore	10	6	26	4	10	21
	Webpack	Home	uiStartup	1161	923	1395	107	1235	1293
			load	977	756	1148	101	1047	1097
			domContentLoaded	971	752	1145	101	1041	1092
			domInteractive	16	12	48	7	14	37
			firstPaint	149	64	355	56	176	275
			backgroundConnect	17	11	84	9	17	31
			firstReactRender	35	32	48	3	36	41
			getState	7	4	18	2	7	12
			initialActions	6	2	26	4	8	13
			loadScripts	968	750	1142	101	1035	1090
			setupStore	8	6	20	2	9	11
Firefox	Browserify	Home	uiStartup	1383	1190	1645	102	1439	1585
			load	1204	1047	1398	78	1261	1335
			domContentLoaded	1204	1046	1397	78	1260	1334
			domInteractive	104	33	272	51	111	249
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	18	117	16	33	66
			firstReactRender	28	23	47	5	29	39
			getState	6	3	45	6	6	12
			initialActions	3	0	68	7	3	8
			loadScripts	1180	1029	1372	78	1235	1316
			setupStore	10	5	92	12	8	32
	Webpack	Home	uiStartup	1607	1355	1960	158	1716	1922
			load	1370	1147	1693	137	1465	1635
			domContentLoaded	1370	1147	1692	136	1465	1634
			domInteractive	104	35	346	58	101	283
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	21	185	17	36	41
			firstReactRender	46	35	66	6	49	56
			getState	6	3	20	2	7	11
			initialActions	3	1	23	2	3	5
			loadScripts	1346	1129	1634	135	1445	1606
			setupStore	12	6	224	24	10	20

Benchmark value 215 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 225 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 47 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 21 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 249 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 283 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 56 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 5 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 252ms | Sum of p95 exceeds: 435.8ms
Sum of all benchmark exceeds: 687.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 844 Bytes (0.02%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-09-23T08:38:16Z

📊 Page Load Benchmark Results

Current Commit: bb1bc1a | Date: 9/23/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.08s (±75ms) 🟡 | historical mean value: 1.06s ⬆️ (historical data)
domContentLoaded-> current mean value: 759ms (±84ms) 🟢 | historical mean value: 740ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 92ms (±128ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.08s	75ms	1.03s	1.41s	1.33s	1.41s
domContentLoaded	759ms	84ms	710ms	1.30s	991ms	1.30s
firstPaint	92ms	128ms	60ms	1.36s	92ms	1.36s
firstContentfulPaint	92ms	128ms	60ms	1.36s	92ms	1.36s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-23T08:38:27Z

Builds ready [bb1bc1a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1247 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1247	1111	1471	63	1288	1350
			load	1065	931	1209	61	1104	1167
			domContentLoaded	1057	925	1203	62	1097	1159
			domInteractive	19	14	65	9	17	47
			firstPaint	562	87	1210	423	1069	1165
			backgroundConnect	221	205	337	13	224	231
			firstReactRender	30	18	153	20	31	46
			getState	16	6	96	11	20	37
			initialActions	7	1	50	7	8	21
			loadScripts	844	706	980	62	881	943
			setupStore	11	7	23	5	14	22
	Webpack	Home	uiStartup	1180	938	1402	109	1258	1323
			load	989	770	1189	102	1058	1129
			domContentLoaded	984	766	1185	102	1054	1123
			domInteractive	17	13	61	9	14	41
			firstPaint	153	65	301	58	187	261
			backgroundConnect	17	11	36	6	18	30
			firstReactRender	37	34	50	3	37	44
			getState	6	4	13	2	6	12
			initialActions	6	2	17	4	9	15
			loadScripts	981	764	1182	102	1050	1120
			setupStore	8	6	22	2	9	12
Firefox	Browserify	Home	uiStartup	1451	1241	1845	118	1514	1677
			load	1254	1091	1464	83	1316	1383
			domContentLoaded	1253	1091	1464	83	1316	1383
			domInteractive	106	33	356	59	116	262
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	19	132	18	37	68
			firstReactRender	30	23	67	7	31	45
			getState	6	3	15	2	6	12
			initialActions	4	0	49	7	3	10
			loadScripts	1227	1071	1393	80	1296	1356
			setupStore	14	5	200	25	9	50
	Webpack	Home	uiStartup	1593	1373	2122	152	1690	1912
			load	1361	1165	1687	132	1451	1624
			domContentLoaded	1360	1165	1687	132	1450	1624
			domInteractive	111	33	337	72	100	315
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	20	78	8	35	42
			firstReactRender	46	37	60	5	50	56
			getState	8	3	150	16	6	12
			initialActions	3	1	22	2	3	6
			loadScripts	1339	1148	1666	133	1428	1602
			setupStore	10	6	111	11	9	18

Benchmark value 1248 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 222 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 30 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 845 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 12 exceeds gate value 11 for chrome browserify home mean setupStore
Benchmark value 47 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 46 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 37 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 21 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 943 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 22 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1451 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1254 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1254 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1677 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 262 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 50 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 47 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 315 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 56 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 377ms | Sum of p95 exceeds: 544.8ms
Sum of all benchmark exceeds: 921.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.56 KiB (0.06%)
ui: 3.71 KiB (0.05%)
common: 576 Bytes (0.01%)

metamaskbot · 2025-09-25T00:08:20Z

📊 Page Load Benchmark Results

Current Commit: 8d74bda | Date: 9/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±69ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 736ms (±66ms) 🟢 | historical mean value: 735ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	69ms	1.02s	1.33s	1.26s	1.33s
domContentLoaded	736ms	66ms	703ms	1.01s	940ms	1.01s
firstPaint	77ms	11ms	60ms	176ms	88ms	176ms
firstContentfulPaint	77ms	11ms	60ms	176ms	88ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-25T00:08:25Z

Builds ready [8d74bda]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1249 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1249	1124	1379	58	1280	1356
			load	1077	982	1182	51	1112	1171
			domContentLoaded	1069	976	1176	50	1105	1152
			domInteractive	19	14	56	9	17	44
			firstPaint	659	114	1189	437	1095	1141
			backgroundConnect	257	242	319	10	260	269
			firstReactRender	25	16	48	6	25	39
			getState	15	5	51	8	19	31
			initialActions	5	0	70	8	6	12
			loadScripts	819	713	917	49	852	901
			setupStore	9	6	27	4	10	17
	Webpack	Home	uiStartup	1136	908	1352	113	1228	1297
			load	950	744	1180	113	1026	1108
			domContentLoaded	946	740	1177	113	1021	1104
			domInteractive	16	12	58	9	14	41
			firstPaint	145	62	256	46	175	234
			backgroundConnect	16	9	37	6	18	29
			firstReactRender	37	32	138	13	36	45
			getState	7	3	26	3	7	12
			initialActions	6	2	14	3	8	11
			loadScripts	943	738	1174	112	1019	1102
			setupStore	8	6	21	3	9	14
Firefox	Browserify	Home	uiStartup	1389	1199	1676	106	1462	1592
			load	1200	1039	1452	85	1262	1349
			domContentLoaded	1200	1039	1451	85	1262	1349
			domInteractive	107	33	501	72	108	236
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	19	125	22	35	103
			firstReactRender	27	23	39	3	28	32
			getState	6	2	42	5	7	11
			initialActions	4	1	38	4	4	8
			loadScripts	1173	1023	1429	83	1234	1328
			setupStore	10	5	50	9	9	33
	Webpack	Home	uiStartup	1582	1397	1909	127	1666	1836
			load	1348	1172	1606	114	1440	1578
			domContentLoaded	1347	1172	1605	114	1440	1578
			domInteractive	103	34	311	47	104	268
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	21	94	9	32	42
			firstReactRender	37	32	62	4	40	46
			getState	6	3	20	3	7	13
			initialActions	4	0	44	5	4	9
			loadScripts	1325	1142	1582	114	1416	1555
			setupStore	12	6	133	13	11	23

Benchmark value 1249 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1077 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1070 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 258 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 45 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 269 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 236 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 103 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 268 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 313ms | Sum of p95 exceeds: 474.8ms
Sum of all benchmark exceeds: 787.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 844 Bytes (0.02%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

fix: solana account switching

1516b28

metamaskbot added the team-accounts-framework Accounts Framework team label Sep 22, 2025

github-actions bot added the size-M label Sep 22, 2025

fix: tests

78cac88

This comment was marked as outdated.

Sign in to view

chore: remove logs

60abe5d

This comment was marked as outdated.

Sign in to view

montelaidev added 2 commits September 22, 2025 22:36

Merge remote-tracking branch 'origin/main' into fix/mul-924

2b25376

fix: test

bb1bc1a

PatrykLucka previously approved these changes Sep 22, 2025

View reviewed changes

montelaidev enabled auto-merge September 23, 2025 01:24

montelaidev dismissed PatrykLucka’s stale review via df0ca85 September 23, 2025 08:08

montelaidev force-pushed the fix/mul-924 branch from df0ca85 to 913f44a Compare September 23, 2025 08:09

github-actions bot added size-L size-M and removed size-M size-L labels Sep 23, 2025

montelaidev force-pushed the fix/mul-924 branch from 913f44a to bb1bc1a Compare September 23, 2025 08:11

This comment was marked as outdated.

Sign in to view

montelaidev requested a review from PatrykLucka September 23, 2025 15:49

PatrykLucka previously approved these changes Sep 24, 2025

View reviewed changes

owencraston previously approved these changes Sep 24, 2025

View reviewed changes

montelaidev added this pull request to the merge queue Sep 24, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2025

montelaidev added this pull request to the merge queue Sep 24, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2025

montelaidev added 2 commits September 25, 2025 07:42

Merge remote-tracking branch 'origin/main' into fix/mul-924

f2b622c

Merge remote-tracking branch 'origin/main' into fix/mul-924

8d74bda

montelaidev dismissed stale reviews from owencraston and PatrykLucka via 8d74bda September 24, 2025 23:42

montelaidev enabled auto-merge September 24, 2025 23:43

owencraston approved these changes Sep 25, 2025

View reviewed changes

PatrykLucka approved these changes Sep 25, 2025

View reviewed changes

montelaidev added this pull request to the merge queue Sep 25, 2025

Merged via the queue into main with commit eb3eb74 Sep 25, 2025
149 checks passed

montelaidev deleted the fix/mul-924 branch September 25, 2025 09:36

github-actions bot locked and limited conversation to collaborators Sep 25, 2025

metamaskbot added the release-13.5.0 Issue or pull request that will be included in release 13.5.0 label Sep 25, 2025

fix: solana account switching #36168

fix: solana account switching #36168

Conversation

montelaidev commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Sep 22, 2025

Uh oh!

metamaskbot commented Sep 22, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 22, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 22, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 22, 2025

Uh oh!

metamaskbot commented Sep 22, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 22, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 23, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 23, 2025

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Sep 25, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

montelaidev commented Sep 22, 2025 •

edited

Loading