Skip to content

Conversation

@itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Sep 22, 2025

Description

Open in GitHub Codespaces

Fixes opr

Changelog

CHANGELOG entry:

Related issues

Fixes: #27694

Manual testing steps

  1. Do what Error: LavaMoat - property "opr" of globalThis is inaccessible under scuttling mode. To learn more visit ** #27694 is saying, and there should not be any error

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr self-assigned this Sep 22, 2025
@itsyoboieltr itsyoboieltr added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Sep 22, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Sep 22, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 7b2bd46 | Date: 9/22/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.08s (±73ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 756ms (±70ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±10ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.08s 73ms 1.03s 1.35s 1.32s 1.35s
domContentLoaded 756ms 70ms 714ms 1.03s 973ms 1.03s
firstPaint 79ms 10ms 64ms 164ms 92ms 164ms
firstContentfulPaint 79ms 10ms 64ms 164ms 92ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [7b2bd46]
UI Startup Metrics (1204 ± 76 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1204106214957612471310
load103492812926910771144
domContentLoaded102792112856910731138
domInteractive18144771739
firstPaint611142129042110491107
backgroundConnect2122022325216223
firstReactRender25174862741
getState14690121727
initialActions50305615
loadScripts822713107769868933
setupStore1052131118
WebpackHomeuiStartup1143915134310612241276
load961752111710010341087
domContentLoaded955747111410010291082
domInteractive15124071437
firstPaint1566230459185278
backgroundConnect16113461729
firstReactRender35325843543
getState64203612
initialActions62214814
loadScripts952745111210010251079
setupStore86162912
FirefoxBrowserifyHomeuiStartup13881187188413014381675
load1197104614058112681343
domContentLoaded1196104614058112671343
domInteractive1053237357114232
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3119103143365
firstReactRender28234553041
getState63667614
initialActions4158739
loadScripts1173103113767812381308
setupStore1159113841
WebpackHomeuiStartup16151369230115717111898
load13741161175112514481617
domContentLoaded13741161175012514481616
domInteractive1083634363104289
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3322197183749
firstReactRender46376664960
getState63424712
initialActions3117236
loadScripts13491144172612614291595
setupStore126137181023
Benchmark value 213 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 223 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1675 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 232 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 41 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 47 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 289 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 60 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 252ms | Sum of p95 exceeds: 446.8ms
Sum of all benchmark exceeds: 698.8ms

Copy link
Member

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this is the suggested solution from Lavamoat team so the change LGTM and the issue is fixed on my end.

image

@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Sep 24, 2025
@itsyoboieltr itsyoboieltr added this pull request to the merge queue Sep 24, 2025
Merged via the queue into main with commit d2e86b6 Sep 24, 2025
152 of 154 checks passed
@itsyoboieltr itsyoboieltr deleted the fix/opr branch September 24, 2025 11:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2025
@metamaskbot metamaskbot added the release-13.5.0 Issue or pull request that will be included in release 13.5.0 label Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.5.0 Issue or pull request that will be included in release 13.5.0 size-XS team-extension-platform Extension Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Error: LavaMoat - property "opr" of globalThis is inaccessible under scuttling mode. To learn more visit **

5 participants