-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: Sidebar POC #36177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
feat: Sidebar POC #36177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (1 files, +0 -1)
👨🔧 @MetaMask/core-extension-ux (7 files, +110 -10)
🔐 @MetaMask/web3auth (1 files, +21 -6)
|
This comment was marked as spam.
This comment was marked as spam.
ec1a9a0 to
ceecf59
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
size-M
team-core-extension-ux
Core Extension UX team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a POC for sidebar
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a Chrome side panel experience with a toggleable default view, context menu entry, environment wiring, and updated UI/CSS/routing to support it.
side_panelentry inapp/manifest/v3/chrome.jsonand permissionssidePanel,contextMenusin_base.json; newsidepanel.htmland build pipeline for it.ENVIRONMENT_TYPE_SIDEPANEL; detect/sidepanel.htmlingetEnvironmentTypeand handle background connections/state like popup.sidePanelIsOpen, include in client-open logic; add context menu “MetaMask Sidepanel” to open panel; initialize and react topreferences.useSidePanelAsDefaultviabrowser.sidePanel.setPanelBehavior; update active tab info on tab activate/update.preferences.useSidePanelAsDefault(default true) with persistence/metadata; exposesetUseSidePanelAsDefaultaction.popupViewandsidePanelView; add i18n keys.app--sidepanelclass; CSS widths for side panel layout; hide app header in side panel when confirmations pending.development/build/scripts.js; minor header/menu logic updates to support side panel.Written by Cursor Bugbot for commit ef3ad68. This will update automatically on new commits. Configure here.