feat: pre-fill Swap tokens with default BIP-44 pairs #36209

micaelae · 2025-09-22T18:29:09Z

Description

The PR updates the default selected tokens when navigating to the Swap page

If the user navigates from the home page, the bip44DefaultPairs entry for eip155 are set as src and dest tokens
If the user navigates from a network's native asset details page (i.e BNB, AVAX), the src is set to the native asset, and dest is set to the network's mapped BRIDGE_CHAINID_COMMON_TOKEN_PAIR token
If the user navigates from any other asset detail page, the src is set to the asset and the dest is set to the BRIDGE_CHAINID_COMMON_TOKEN_PAIR for the network

Changelog

CHANGELOG entry: feat: pre-fill Swap tokens with default BIP-44 pairs from remote config

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3032

Manual testing steps

Navigate to Swap from home page
Verify that ETH -> mUSD is pre-filled by default
Navigate to Swap from linea:ETH asset page
Verify that linea:ETH -> linea:mUSD is pre-filled by default
Navigate to Swap from any ERC20 asset page
Verify that the asset -> BRIDGE_CHAINID_COMMON_TOKEN_PAIR mapping for the network is pre-filled by default
Verify that deep links still work using this generator: https://montoya.github.io/deeplinker/swap

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-09-22T18:31:48Z

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (5 files, +177 -28)

📁 ui/
- 📁 ducks/
  - 📁 bridge/
    - 📄 selectors.test.ts +1 -1
    - 📄 selectors.ts +34 -4
    - 📄 utils.ts +4 -7
- 📁 hooks/
  - 📁 bridge/
    - 📄 useBridging.test.ts +94 -3
    - 📄 useBridging.ts +44 -13

metamaskbot · 2025-09-23T16:58:51Z

📊 Page Load Benchmark Results

Current Commit: a1fe60a | Date: 9/23/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±74ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 733ms (±84ms) 🟢 | historical mean value: 741ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 88ms (±125ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	74ms	1.00s	1.37s	1.29s	1.37s
domContentLoaded	733ms	84ms	697ms	1.27s	975ms	1.27s
firstPaint	88ms	125ms	56ms	1.33s	88ms	1.33s
firstContentfulPaint	88ms	125ms	56ms	1.33s	88ms	1.33s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-23T16:59:02Z

Builds ready [a1fe60a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1216 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1216	1091	1553	75	1252	1341
			load	1049	915	1337	73	1087	1181
			domContentLoaded	1041	895	1329	74	1079	1174
			domInteractive	18	13	81	9	16	40
			firstPaint	691	141	1247	414	1062	1159
			backgroundConnect	216	201	343	14	219	233
			firstReactRender	24	16	51	6	25	39
			getState	13	5	60	7	16	24
			initialActions	4	0	66	7	5	8
			loadScripts	832	685	1106	72	869	967
			setupStore	9	5	26	4	10	22
	Webpack	Home	uiStartup	1138	907	1349	114	1226	1294
			load	954	748	1176	113	1030	1098
			domContentLoaded	949	744	1172	113	1026	1093
			domInteractive	16	12	61	9	13	41
			firstPaint	144	63	330	44	167	229
			backgroundConnect	16	10	35	6	18	29
			firstReactRender	38	32	118	15	35	57
			getState	6	4	18	3	8	12
			initialActions	5	1	19	4	8	12
			loadScripts	946	742	1170	113	1023	1090
			setupStore	8	6	21	3	8	18
Firefox	Browserify	Home	uiStartup	1506	1285	1889	126	1581	1739
			load	1298	1102	1508	94	1356	1468
			domContentLoaded	1297	1102	1507	94	1355	1467
			domInteractive	110	35	368	58	116	236
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	36	18	102	16	37	78
			firstReactRender	32	25	53	7	34	49
			getState	8	2	79	10	7	17
			initialActions	4	1	85	8	4	8
			loadScripts	1269	1086	1480	90	1327	1437
			setupStore	12	5	118	14	9	32
	Webpack	Home	uiStartup	1577	1392	1895	129	1671	1855
			load	1345	1170	1609	121	1448	1581
			domContentLoaded	1345	1169	1608	120	1447	1581
			domInteractive	104	34	325	56	105	285
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	21	93	9	37	41
			firstReactRender	46	39	61	5	49	56
			getState	6	3	15	2	6	10
			initialActions	3	1	26	3	3	4
			loadScripts	1322	1143	1586	122	1426	1562
			setupStore	9	6	46	6	9	19

Benchmark value 217 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 833 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 967 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 22 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1506 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1298 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1298 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1270 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1739 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 236 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 78 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 285 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 56 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 4 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 515ms | Sum of p95 exceeds: 534.8ms
Sum of all benchmark exceeds: 1049.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 1.22 KiB (0.02%)
common: 250 Bytes (0%)

metamaskbot · 2025-09-23T17:52:15Z

📊 Page Load Benchmark Results

Current Commit: 32db487 | Date: 9/23/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±77ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 742ms (±89ms) 🟢 | historical mean value: 741ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±43ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	77ms	1.01s	1.34s	1.30s	1.34s
domContentLoaded	742ms	89ms	700ms	1.29s	986ms	1.29s
firstPaint	81ms	43ms	60ms	500ms	88ms	500ms
firstContentfulPaint	81ms	43ms	60ms	500ms	88ms	500ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-23T17:52:20Z

Builds ready [32db487]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1192 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1192	1059	1342	62	1233	1295
			load	1028	920	1146	58	1068	1140
			domContentLoaded	1021	917	1140	58	1062	1133
			domInteractive	17	13	53	6	16	34
			firstPaint	676	87	1147	405	1044	1104
			backgroundConnect	211	199	238	6	213	223
			firstReactRender	24	19	43	5	24	32
			getState	13	5	37	6	16	23
			initialActions	5	0	70	9	5	19
			loadScripts	816	697	936	57	854	924
			setupStore	9	6	21	2	9	15
	Webpack	Home	uiStartup	1151	926	1333	109	1240	1295
			load	968	760	1126	101	1046	1083
			domContentLoaded	963	756	1121	101	1042	1080
			domInteractive	16	12	50	9	14	45
			firstPaint	170	63	472	77	183	330
			backgroundConnect	16	10	36	6	15	30
			firstReactRender	35	33	45	3	35	41
			getState	6	4	19	2	6	11
			initialActions	6	2	19	4	8	14
			loadScripts	960	754	1119	101	1040	1078
			setupStore	8	6	19	2	9	12
Firefox	Browserify	Home	uiStartup	1513	1328	2034	134	1572	1857
			load	1299	1153	1545	84	1355	1447
			domContentLoaded	1299	1152	1544	84	1355	1446
			domInteractive	107	34	335	50	116	222
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	37	20	219	28	36	88
			firstReactRender	32	24	92	9	33	48
			getState	8	2	179	19	6	13
			initialActions	7	1	201	27	3	9
			loadScripts	1271	1133	1492	83	1329	1418
			setupStore	12	5	110	15	9	32
	Webpack	Home	uiStartup	1636	1439	2161	140	1734	1911
			load	1386	1199	1680	118	1480	1633
			domContentLoaded	1385	1198	1679	118	1480	1632
			domInteractive	106	40	315	45	107	210
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	22	94	9	38	45
			firstReactRender	49	38	66	6	52	59
			getState	7	3	26	3	7	13
			initialActions	4	1	57	6	4	10
			loadScripts	1361	1178	1657	119	1456	1605
			setupStore	10	6	35	5	11	25

Benchmark value 212 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 224 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1513 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1300 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1300 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 38 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1272 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1857 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 222 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 88 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1637 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1386 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1386 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 50 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1361 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 210 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 59 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 566ms | Sum of p95 exceeds: 555.8ms
Sum of all benchmark exceeds: 1121.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 1.22 KiB (0.02%)
common: 250 Bytes (0%)

ui/components/app/wallet-overview/coin-buttons.tsx

ui/hooks/bridge/useBridging.ts

wip

7a2e679

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Sep 22, 2025

Merge branch 'main' into swaps3032-prefill-tokens

8f33e2e

github-actions bot added the size-M label Sep 22, 2025

micaelae and others added 6 commits September 22, 2025 11:43

refactor: useBridging

172fea6

fix: if srcToken is present, add default toToken to URL

ae67e76

chore: add comments

97db74a

chore: remove comments and logs

0c27a4d

Merge branch 'main' into swaps3032-prefill-tokens

fda7a3e

fix: tests

a1fe60a

micaelae added 2 commits September 23, 2025 10:14

test: add useBridging unit test

0d5aa73

chore: comments

32db487

micaelae marked this pull request as ready for review September 23, 2025 17:52

micaelae requested a review from a team as a code owner September 23, 2025 17:52

cursor bot reviewed Sep 23, 2025

View reviewed changes

ui/components/app/wallet-overview/coin-buttons.tsx Show resolved Hide resolved

ui/hooks/bridge/useBridging.ts Show resolved Hide resolved

SteP-n-s approved these changes Sep 23, 2025

View reviewed changes

micaelae enabled auto-merge September 24, 2025 15:37

ghgoodreau approved these changes Sep 24, 2025

View reviewed changes

micaelae added this pull request to the merge queue Sep 24, 2025

Merged via the queue into main with commit fa04038 Sep 24, 2025
149 checks passed

micaelae deleted the swaps3032-prefill-tokens branch September 24, 2025 17:28

github-actions bot locked and limited conversation to collaborators Sep 24, 2025

metamaskbot added the release-13.5.0 Issue or pull request that will be included in release 13.5.0 label Sep 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: pre-fill Swap tokens with default BIP-44 pairs #36209

feat: pre-fill Swap tokens with default BIP-44 pairs #36209

micaelae commented Sep 22, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Sep 22, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Sep 23, 2025

Uh oh!

metamaskbot commented Sep 23, 2025

Uh oh!

metamaskbot commented Sep 23, 2025

Uh oh!

metamaskbot commented Sep 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: pre-fill Swap tokens with default BIP-44 pairs #36209

feat: pre-fill Swap tokens with default BIP-44 pairs #36209

Conversation

micaelae commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Sep 23, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 23, 2025

Uh oh!

metamaskbot commented Sep 23, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

micaelae commented Sep 22, 2025 •

edited

Loading

metamaskbot commented Sep 22, 2025 •

edited

Loading