Skip to content

chore: Bump @metamask/eslint-config-typescript from 14.0.0 to 14.1.0 #3734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Bump @metamask/eslint-config-typescript from 14.0.0 to 14.1.0 #3734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
"@metamask/eslint-config-browser": "^14.0.0",
"@metamask/eslint-config-jest": "^14.0.0",
"@metamask/eslint-config-nodejs": "^14.0.0",
"@metamask/eslint-config-typescript": "^14.0.0",
"@metamask/eslint-config-typescript": "^14.1.0",
Copy link

@cursor cursor bot Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: MetaMask ESLint Upgrade: Dependency Hell

Upgrading @metamask/eslint-config-typescript to 14.1.0 creates a peer dependency mismatch. The new version requires @metamask/eslint-config@^14.1.0, but the project still has @metamask/eslint-config@^14.0.0 installed. This will cause yarn to warn about unmet peer dependencies and may result in unexpected ESLint behavior.

Fix in Cursor Fix in Web

Copy link

@cursor cursor bot Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Outdated dependency causes peer warnings.

The upgraded @metamask/[email protected] requires typescript-eslint@^8.24 as a peer dependency, but the project has typescript-eslint@^8.6.0 which may resolve to version 8.6.0. This doesn't satisfy the minimum version requirement of 8.24.0 and will cause peer dependency warnings.

Fix in Cursor Fix in Web

"@metamask/utils": "^11.8.1",
"@swc/core": "1.11.31",
"@ts-bridge/cli": "^0.6.1",
Expand Down
16 changes: 8 additions & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3259,20 +3259,20 @@ __metadata:
languageName: node
linkType: hard

"@metamask/eslint-config-typescript@npm:^14.0.0":
version: 14.0.0
resolution: "@metamask/eslint-config-typescript@npm:14.0.0"
"@metamask/eslint-config-typescript@npm:^14.1.0":
version: 14.1.0
resolution: "@metamask/eslint-config-typescript@npm:14.1.0"
dependencies:
"@eslint/js": "npm:^9.11.0"
peerDependencies:
"@metamask/eslint-config": ^14.0.0
"@metamask/eslint-config": ^14.1.0
eslint: ^9.11.0
eslint-import-resolver-typescript: ^3.6.3
eslint-plugin-import-x: ^4.3.0
eslint-plugin-jsdoc: ^50.2.4
typescript: ">=4.8.4 <5.6"
typescript-eslint: ^8.6.0
checksum: 10/cbf0a9e8523292d41140f90630863d034301422f16e6a42e5881c3593e83c07d0394787563d3e88fee02aa22042a9ca974363d3f192374e31bb0729c6ca8734e
typescript: ">=4.8.4 <5.9.0"
typescript-eslint: ^8.24
checksum: 10/697b61648969f5f53179b8cf83ffb1aa1dbe5ce9ad4f7f4ed0bc4e436c510f1d28543e764467fd880ccb2579b5810e78eee63f972daa55f1b599844b53ea13ca
languageName: node
linkType: hard

Expand Down Expand Up @@ -16484,7 +16484,7 @@ __metadata:
"@metamask/eslint-config-browser": "npm:^14.0.0"
"@metamask/eslint-config-jest": "npm:^14.0.0"
"@metamask/eslint-config-nodejs": "npm:^14.0.0"
"@metamask/eslint-config-typescript": "npm:^14.0.0"
"@metamask/eslint-config-typescript": "npm:^14.1.0"
"@metamask/utils": "npm:^11.8.1"
"@swc/core": "npm:1.11.31"
"@ts-bridge/cli": "npm:^0.6.1"
Expand Down
Loading