Skip to content

Conversation

SirajShaik-MSFT
Copy link
Collaborator

No description provided.

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/bots/design/bots.md 80 29 link
msteams-platform/bots/how-to/authentication/bot-sso-register-aad.md 87 92 link
msteams-platform/bots/how-to/teams-conversational-ai/ai-ux.md 89 33 link
msteams-platform/bots/how-to/teams-conversational-ai/assistants-api-quick-start.md 90 11 link
msteams-platform/concepts/build-and-test/manage-your-apps-in-developer-portal.md 91 18 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

Copy link
Contributor

* Scope and permissions

With the app (client) ID and client secret provided, the Bot Framework Token Store exchanges the token for a graph token with defined permissions.
With the app (client) ID and client secret provided, the Teams AI library Token Store exchanges the token for a graph token with defined permissions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be a simple working swap. @MSFTRickyCastaneda what is the equivalent token names here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree started GC with engineering to help clarify

Copy link
Contributor

Learn Build status updates of commit 2f9c93f:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit 2f9c93fd3ffe9a655311a3288807603f3f5abd5c in branch SirajShaik-MSFT/BotFrameworkSDKandTeamsFXSDK-3 of repository https://github.com/MicrosoftDocs/msteams-docs into branch main (commit afb09ef4aaa6872ab32d6747cb45c3422adba76f). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/bots/design/bots.md 80 29 link
msteams-platform/bots/how-to/authentication/bot-sso-register-aad.md 87 92 link
msteams-platform/bots/how-to/teams-conversational-ai/ai-ux.md 89 33 link
msteams-platform/bots/how-to/teams-conversational-ai/assistants-api-quick-start.md 90 11 link
msteams-platform/concepts/build-and-test/manage-your-apps-in-developer-portal.md 91 18 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/bots/design/bots.md 80 29 link
msteams-platform/bots/how-to/authentication/bot-sso-register-aad.md 87 92 link
msteams-platform/bots/how-to/teams-conversational-ai/ai-ux.md 88 32 link
msteams-platform/bots/how-to/teams-conversational-ai/assistants-api-quick-start.md 90 11 link
msteams-platform/concepts/build-and-test/manage-your-apps-in-developer-portal.md 91 18 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

Copy link
Contributor

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/bots/design/bots.md 80 29 link
msteams-platform/bots/how-to/authentication/bot-sso-register-aad.md 87 92 link
msteams-platform/bots/how-to/teams-conversational-ai/assistants-api-quick-start.md 90 11 link
msteams-platform/concepts/build-and-test/manage-your-apps-in-developer-portal.md 91 18 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

Copy link
Contributor

Learn Build status updates of commit 18ff4c7:

✅ Validation status: passed

File Status Preview URL Details
msteams-platform/bots/design/bots.md ✅Succeeded View
msteams-platform/bots/how-to/authentication/bot-sso-register-aad.md ✅Succeeded View
msteams-platform/bots/how-to/teams-conversational-ai/assistants-api-quick-start.md ✅Succeeded View
msteams-platform/concepts/build-and-test/manage-your-apps-in-developer-portal.md ✅Succeeded View

For more details, please refer to the build report.

Copy link
Collaborator

@MSFTRickyCastaneda MSFTRickyCastaneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see what engineering says about the tokens then we can change or merge if its correct.

* Scope and permissions

With the app (client) ID and client secret provided, the Bot Framework Token Store exchanges the token for a graph token with defined permissions.
With the app (client) ID and client secret provided, the Teams AI library Token Store exchanges the token for a graph token with defined permissions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree started GC with engineering to help clarify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants